MegaGlest Forum

Archives (read only) => Vanilla Glest => Bug report => Topic started by: ZaRo on 3 November 2009, 10:17:33

Title: particle xml isn't validated
Post by: ZaRo on 3 November 2009, 10:17:33

If you type "<trajectory type="spiral2">" in the particle_proj2.xml (from archmage) the game crashes the first time you fire off the spell.

Best regards
ZaRo

Title: Re: particle xml isn't validated
Post by: -Archmage- on 3 November 2009, 12:57:47

Well there is no such thing as "spiral2", why did you put it in there?

Title: Re: particle xml isn't validated
Post by: ZaRo on 3 November 2009, 13:09:40

Quote from: -Archmage- on  3 November 2009, 12:57:47

Well there is no such thing as "spiral2", why did you put it in there?

I know :) That's the whole point of my post, that I should get an error when I type junk into the xml files (it's called fuzzy testing, and yes, it should not be done by hand, but I'm bored).

The general idea is to have a list of things that I can put in the xml files without glest crapping out on me. (Documentation, anyone?)

Best regards
ZaRo

Title: Re: particle xml isn't validated
Post by: silnarm on 3 November 2009, 19:49:14

Quote from: ZaRo on  3 November 2009, 13:09:40

I know :) That's the whole point of my post, that I should get an error when I type junk into the xml files (it's called fuzzy testing, and yes, it should not be done by hand, but I'm bored).

The general idea is to have a list of things that I can put in the xml files without glest crapping out on me. (Documentation, anyone?)

https://docs.megaglest.org/XML_Definitions

Interesting crash though, it must be testing the string only when used, dodgy.

Title: Re: particle xml isn't validated
Post by: ZaRo on 9 November 2009, 09:48:41

Quote from: silnarm on  3 November 2009, 19:49:14

Quote from: ZaRo on  3 November 2009, 13:09:40

I know :) That's the whole point of my post, that I should get an error when I type junk into the xml files (it's called fuzzy testing, and yes, it should not be done by hand, but I'm bored).

The general idea is to have a list of things that I can put in the xml files without glest crapping out on me. (Documentation, anyone?)

...

Interesting crash though, it must be testing the string only when used, dodgy.

Thank you. Any idea when it will be fixed?

Best Regards
ZaRo

Title: Re: particle xml isn't validated
Post by: hailstone on 9 November 2009, 11:43:45

In GAE trunk r306 it will say "Exception: Unknown particle system trajectory: spriral2". We have replaced xerces with TinyXML which doesn't have any schema validation but we should have schema files so that it can be validated externally.

Is this the kind of error you are after?

Title: Re: particle xml isn't validated
Post by: ZaRo on 9 November 2009, 12:50:32

Quote from: hailstone on  9 November 2009, 11:43:45

In GAE trunk r306 it will say "Exception: Unknown particle system trajectory: spriral2". We have replaced xerces with TinyXML which doesn't have any schema validation but we should have schema files so that it can be validated externally.

Is this the kind of error you are after?

If it's done when loading a map, yes, then it's exactly what I'm after.

Eternal validation? So you run 'validate' on your xml files and it tells "File abc.xml contains error "blah" at line Bleh"? That would be soooooo awsome! Keep that going :D

Best regards
ZaRo