MegaGlest Forum

MegaGlest => Bug reports => Closed bug reports => Topic started by: atze on 8 October 2013, 18:04:18

Title: [fixed] r4598: rock textures are gone
Post by: atze on 8 October 2013, 18:04:18

Testing svn rev. 4598 I noticed that rock textures are not longer rendered.

Here are 2 screenshots with the same settings (tileset), for better understanding.

Screenshot 3.8.0 beta1 :

(click to show/hide)

(http://i39.tinypic.com/2vsmccl.png)

Screenshot svn rev. 4598 :

(click to show/hide)

(http://i40.tinypic.com/2v7x6w8.png)

My system:

Linux 64 bit, ATI driver 8.97.100.7, running MegaGlest r4598 (which I compiled myself)

Title: Re: r4598: rock textures are gone
Post by: MuwuM on 8 October 2013, 19:20:58

It seams to be a problem with the cliff detection, as not all cliffs are rendered as cliffs. See screenshot.

(click to show/hide)

(http://img849.imageshack.us/img849/2517/cibv.jpg)
(http://img202.imageshack.us/img202/1316/n84h.png)

Title: Re: r4598: rock textures are gone
Post by: MuwuM on 15 October 2013, 22:31:25

I detected an difference in calculation of isCliff.  It's different for map editor and game. The tolerance for map_preview seems to be better for more cliffs.

map.cpp 1617   versus  map_preview.cpp 76

I debugged values for a cell that is cliff in editor but in game it is not:

Code: [Select]

(STREFLOP) X: 88 Y: 121 K: -1 L: -1-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: -1 L: 0-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: -1 L: 1-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: -1-> Cliff: 6.000000 compare: 1.083045 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: 1-> Cliff: 6.000000 compare: 0.252266 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: -1-> Cliff: 6.000000 compare: 2.475202 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: 0-> Cliff: 6.000000 compare: 0.134478 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: 1-> Cliff: 6.000000 compare: 0.318521 smooth

(http://muwum.org/glest/mageditor.png)

Here is the debugging for a field with working cliff.

Code: [Select]

(STREFLOP) X: 100 Y: 117 K: -1 L: -1-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: -1 L: 0-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: -1 L: 1-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: 0 L: -1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 0 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 0 L: 1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: -1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: 1-> Cliff: 6.000000 compare: 0.000000 smooth

(http://muwum.org/glest/mageditor2.png)

Title: Re: r4598: rock textures are gone
Post by: softcoder on 17 October 2013, 03:27:25

Try svn, I think i fixed this bug

Title: Re: r4598: rock textures are gone
Post by: MuwuM on 17 October 2013, 18:48:21

fixed for me