MegaGlest Forum
MegaGlest => Bug reports => Topic started by: ctz on 20 October 2013, 01:36:01
-
Norsemen faction:
thrull -> thrall (https://en.wikipedia.org/wiki/Thrall). Thrull is not a word.
med_bar -> mead_bar, and med -> mead.
flyingvalkyrie -> flying_valkyrie.
thortotem -> thor_totem.
*_berzerk (3 units) -> *_berserk (https://en.wikipedia.org/wiki/Berserker).
Indian faction:
firegolem should be fire_golem.
bigtent -> big_tent.
mainteepee -> main_teepee, or perhaps just teepee, since the other tents are called *tent, and "main teepee" sounds boring.
-
Also:
Factions:
Indian:
horsefarm -> horse_farm
roundtent -> round_tent
bullfood -> bull_food
iron_advanced -> advanced_iron (strangely Norsemen get this right)
Norseman:
mistletree -> mistle_tree
Regarding units ending in "_berzerk", I feel it should either be "berserk_*" or "_berserker"
But while we're discussing name changes, I feel that the "Indian" faction is horribly named. I mean, they look nothing like Indians! Could you see Gandhi leading those bunch? They resemble natives. I feel they should be renamed to "natives". Or something else that fits them. I'd rather not name them after a specific type or tribe of native people, however. They're fantasy and do not resemble any one type well.
Tilesets:
Similarly, the desert2 tileset should be renamed to desert. From a player's perspective, the versioning is noise.
The mediterran tileset should be renamed to mediterranean. Because the creator was too lazy to Google how to spell the name right.
Somewhat relatedly, winter and winter_forest are very similar. Do we need to include both with the game?
Maps:
2rivers -> two_rivers
6isle -> six_isles
lakesway -> lakes_way (or lake_sway?)
land_of_plenty2 -> land_of_plenty
megakill3vs1 -> mega_kill_3v1
riverway2 -> riverway
showdown_3way -> showdown_threeway
team_island4 -> team_island_4v4
tropical4v4 -> tropical_4v4
tt_goldrush_v2 -> goldrush
wadi_nefud2 -> wadi_nefud
ally_resist and ally_resist_clone are odd. Similar names, similar maps. Slight differences, however. I don't see why we need both. Clone seems to be better designed. Likewise for conflict and conflict6xtreed. I feel that a compromise between those two would be best, though. The former has too few trees and the latter has too many.
The usage of numbering to indicate how players are setup is often inconsistent and can be confusing. I would personally prefer to change the metadata stored with maps so that we can include "player layout" as a field. Possibilities include "free for all", "x on x", "x on y" (where x and y are any positive integer that sum up the total number of players, eg, "4 on 4"). This information can be displayed where the map size and player count is already displayed.
Scenarios:
amazones - > amazons
amazones_light -> amazons_light
Other:
Magic's faction image is so radically different than the others. I feel consistency would look better.
-
Regarding units ending in "_berzerk", I feel it should either be "berserk_*" or "_berserker"
But while we're discussing name changes, I feel that the "Indian" faction is horribly named. I mean, they look nothing like Indians! Could you see Gandhi leading those bunch? They resemble natives. I feel they should be renamed to "natives". Or something else that fits them. I'd rather not name them after a specific type or tribe of native people, however. They're fantasy and do not resemble any one type well.
"Bezerk" is just a misspelling, I would recommend calling the Indians "Native_Americans" since "Natives" is a little too ambiguous.
-
All of these names were the names of the unit folders created during the original faction creation. It is only recently that we even allowed translated names thus opening the ability to name things properly. For anyone wanting to fix it, please join the techtree project on transifex and fix the english translations of the techtrees.
Thanks
-
thrull->thrall
and
med->mead
are changes that are maybe worth to be fixed in the file names :-/
-
On a side note, note that changing file names may damage scenarios, etc, that depend on unit names. And some of these scenarios are not part of the MegaPack. The use of translations would probably be best, unless we want to create a version that is not backwards compatible.
-
The use of translations would probably be best...
^ It has been done some time ago> Megapack tech tree - language corrections (English) and Polish translation (https://forum.megaglest.org/index.php?topic=9059.0)
... are changes that are maybe worth to be fixed in the file names :-/
... unless we want to create a version that is not backwards compatible.
^ It has been started and is in a fairly advanced stage of development (has long been "partly" available for viewing commenting and translating at >Transifex (https://www.transifex.com/projects/p/megaglest-mods-techtrees/resource/megapack_c11/) ),
but slightly set aside due to work on the "main patch" and recently because of the wait for a stable (without CRC's etc.) version in which we could successfully test both of them.
... but I want to emphasize:
This topic is a very ... very useful due to the more ideas of new/better names.
-
Do not rename anything, this will make more problems (for all of the reasons mentioned above). Just set the name in the translation file to whatever makes sense.