MegaGlest Forum

MegaGlest => Bug reports => Closed bug reports => Topic started by: FreshDumbledore on 24 May 2014, 17:49:29

Title: [fixed]attack boosts: boosting sight has no effect
Post by: FreshDumbledore on 24 May 2014, 17:49:29

Hello,

applied a sight boost seems to have no effect. The increased sight is shown in the units stats (like 15+20) but it still visually 'sees' 15 fields. Also tried with the multiplier=true option, didnt help.

Example xml:

         <attack-boost>
            <allow-multiple-boosts value="false" />
            <radius value="5" />
            <target value="all" include-self="true">
            </target>
            <sight value="20" value-percent-multipler="false" />
         </attack-boost>

Can someone test/confirm this bug so i know its not related to my xml's?

if it matters:
megaglest v3.9.1
Compiled using: GNUC: 40403 [64bit] on: Jan 18 2014 17:44:55 platform: Linux-X64 endianness: little
GIT: [Rev: 4628.11ac54a] - using STREFLOP [SSE] - [no-denormals]

binary installation on gentoo linux with a 3.12 kernel

Regards

Title: Re: attack boosts: boosting sight has no effect
Post by: titi on 22 December 2014, 00:50:45

Update: I tried this and it still does not work with git revision from 21th december 2014

@softcoder: To test, just temporary raise the view boost of the roman general to 20 for his stop skill and try it. ( you can use one of the savegames about boost problems to test )


is this still a problem?  ( many things changed with boosts in git version )

Title: Re: attack boosts: boosting sight has no effect
Post by: softcoder on 22 December 2014, 01:24:36

Give this git rev a try: https://github.com/MegaGlest/megaglest-source/commit/b0f7b078f6bd1eb969d5ec841b9b9d7fa9e3cd2d (https://github.com/MegaGlest/megaglest-source/commit/b0f7b078f6bd1eb969d5ec841b9b9d7fa9e3cd2d)

Title: Re: attack boosts: boosting sight has no effect
Post by: titi on 22 December 2014, 02:18:10

Does work a bit, but buildings still have trouble. Somehow the view sight is only calculated when units move ( fog of war calculation ). maybe this must be manually triggered if the boost is applied for buildings ?

Title: Re: attack boosts: boosting sight has no effect
Post by: softcoder on 22 December 2014, 04:28:34

Missed a few areas in the code, i think we have it now: https://github.com/MegaGlest/megaglest-source/commit/92a113ddfa4b9d889d588a7abbd53c52eec84d2d (https://github.com/MegaGlest/megaglest-source/commit/92a113ddfa4b9d889d588a7abbd53c52eec84d2d)

Title: Re: attack boosts: boosting sight has no effect
Post by: titi on 23 December 2014, 01:22:14

Last problem was fixed with https://github.com/MegaGlest/megaglest-source/commit/8925a8997c3031e83700620db960f369c6f98f35