[fixed]v.3.10.0-beta shared resources, killed our cpu, human stuck with debt

[filux]

When cpu in my team was killed (completely) then I stuck with "team debt" and I couldn't build or produce anything.



... also cpu is stealing a bit to much, somewhere should be added some limit for this.

[titi]

 

[softcoder]

I'm not sure what really to do here. Setting to 0 would make unfair as team mates on a losing team make big debt on purpose while team is being destroyed and then would not have to pay it back. I think we just leave it like the way it is or suggest a faire compromise.

[filux]

In my opinion I just should have the ability to pay off the debt (min. 190+, full 2190 for "clear situation"), it wasn't possible because I had maximum 2000/2000, it was a limit and I couldn't get more.

[titi]

I think the resource of the dying faction must be given to the teammates ( if their faction supports if ).

for example gold:
4 players in the team
faction 1 2 3 use resource gold faction 4 is a non gold faction.

example1:
State:
Team has 200 gold,
dying faction1 has -8000 gold.

Now faction 1 dies:
this means faction 2 and 3 inherit -4000 gold each.
Faction 4 is not effected.


example2:
State:
Team has 2000 gold,
dying faction1 has 8000 gold.

Now faction 1 dies:
this means faction 2 and 3 inherit 4000 gold each. But ... if they cannot store this amount of gold its lost!
Faction 4 is not effected.

[titi]

I know its not too easy to do, but filux can you prepare a savegame that will show this trouble (with CPU teammates) ?

[filux]

Example save game with "stuck status", [Rev: 4985.2ec8dd9].

[titi]

we don't have the map "face_off"
pleas upload it so we can test.

[filux]

face-off.mgm map

[softcoder]

Ok fixed in git, when the players units are all dead, the teams resources will not include anything related to dead players.

[titi_son]

I think this must be fix by using the storage of the whole team as max storage.
So filux would be able to mine more gold even though his storage is full already.
This is not only negative for the left players because if the cpu had 2000 wood they can keep it (aslong as the team has enough storage)

[softcoder]

Why dont you explain the problem with the current fix? What is wrong?

[titi_son]

Why dont you explain the problem with the current fix? What is wrong?

As i posted i didn't knew about the bug either.
EDIT:I removed your fix for this problem in the pull request.

My idea to fix this Problem is to share the resource storage of a team too. By this the team still keeps the debts, but can pay for it. Another benefit is that we don't need to to calculate a death state of a faction.

Here is how filux save game starts


How much gold you can store is now calculated on a team basis. This means you can have more gold in your faction than you can store in your faction.


By this the debts can be paid back.


Pull Request: https://github.com/MegaGlest/megaglest-source/pull/44
EDIT2:Sry i made a really dump mistake  Now it's working

[titi]

This is fixed now