Author Topic: Paradigms  (Read 1263 times)

daniel.santos

  • Guest
Paradigms
« on: 12 September 2009, 18:14:29 »
Silnarm,

there are a lot of paradigms that exist for a good reason, please try to be aware of them.  The files global/config.cpp/h aren't supposed to be manually edited.  Rather, you should edit config.db and run the mkconfig.sh script.  If you're on windows, just install cygwin (personally, I can't use a windows machine without Cygwin on it).  If you need to modify the behavior of config.cpp/h aisde from just modifying values, modify config.cpp/h.template and then re-run mkconfig.sh.  I see that you removed some vaues that were "future use".  I agree that they probably shouldn't be popping up in the .ini file if they aren't actually being used, but let's comment them out (in the config.db) rather than deleting them (like MiscLowMemory, which was put in for the animation revamp that never happened).

I'm also not sure it's a good idea to omit the map_editor directory and other such directories that may not always change in various branches, tags, etc..  I see that the data directory was removed from just about everything and I agree that downloading that data repeatedly is a pain.  None the less, when a file doesn't change, it doesn't take up any extra storage on the subversion server.  When you copy files on the server with "svn copy", it only makes a new reference to the file -- locally is a different story. :)  Maybe you guys discussed this somewhere that I haven't caught up with yet, but we have changed some of those files and they will continue to change, so maybe we can discuss this at some point.

EDIT: please no generated files in the tree :) http://glestae.svn.sourceforge.net/viewvc/glestae/branches/tinyxml/source/tiny_test/Debug/.  Test code is fine, just not the generated files.
« Last Edit: 12 September 2009, 18:56:21 by daniel.santos »

silnarm

  • Local Moderator
  • Behemoth
  • ********
  • Posts: 1,373
    • View Profile
Re: Paradigms
« Reply #1 on: 13 September 2009, 00:12:58 »
there are a lot of paradigms that exist for a good reason, please try to be aware of them.  The files global/config.cpp/h aren't supposed to be manually edited.  Rather, you should edit config.db and run the mkconfig.sh script.

I was aware, it's something on the list of things to talk about.  If there's a shell script needed to maintain any of the source tree, then frankly, that shell script needs to go.  I think the only acceptable place for shell scripts is in mk/linux.

I'm not one to try and make a linux install look/feel like windoze, and vice-versa. I don't want to have to install Cygwin just to run a shell script, and I'm not going to.  I do of course see the point of the system, and editing that stuff by hand is not exactly fun anyway ;)  I'll re-write the script in Perl.

I see that you removed some vaues that were "future use".  I agree that they probably shouldn't be popping up in the .ini file if they aren't actually being used, but let's comment them out (in the config.db) rather than deleting them (like MiscLowMemory, which was put in for the animation revamp that never happened).

A consequence of the above, I just wanted them out for now and I wasn't running the script, they should still be in config.db...

As to the rest, you'll have to talk to Hailstone, regarding the data, I think there was some concern over having lots of binary files on sourceforge, but Hailstone will have to clarify that one.
Glest Advanced Engine - Code Monkey

Timeline | Downloads

hailstone

  • Local Moderator
  • Battle Machine
  • ********
  • Posts: 1,568
    • View Profile
Re: Paradigms
« Reply #2 on: 13 September 2009, 01:09:30 »
How do I edit the db file?

I think the data is better managed as a separate project as well as being a time consuming and unnecessary checkout. I've found it easier without it in each branch anyway.

Quote
please no generated files in the tree
I must have just committed the whole directory. Oops  :-[ The branch could probably be deleted now since it's been merged with trunk. Although it will need to be tested for the network code. I'm not sure if it's marshalling exactly the same as xerces.
Glest Advanced Engine - Admin/Programmer
https://sourceforge.net/projects/glestae/

daniel.santos

  • Guest
Re: Paradigms
« Reply #3 on: 14 September 2009, 03:06:19 »
I wouldn't mind if the "Debug" directory was deleted, but please don't permanently delete any files that were ever supposed to be there, it's really best to leave it all in the repository for historical purposes, even if it gets moved.  I don't mind if the branch stays there, personally.

The .db file is very straight forward to edit.  Just set tabs to 4 spaces and it should be pretty intuitive (I added column headers).  I guess I can add some more verbose instructions to the file.  To generate the config.cpp/h, just run away, I mean run the ./mkconfig.sh file from the directory in which it's located.