Author Topic: Typo (Read 3597 times)

ZaRo · « **on:** 3 November 2009, 09:12:02 »

You shouldn't do "string ro resourceClass"

Place: source\glest_game\types\resource_type.cpp line 121

Picture:

And yes, I know that "fun" isn't a resourceClass

Best regards
ZaRo

hailstone · « **Reply #1 on:** 3 November 2009, 21:24:31 »

What Glest version is this?

ZaRo · « **Reply #2 on:** 6 November 2009, 07:28:23 »

Quote from: hailstone on 3 November 2009, 21:24:31

What Glest version is this?

glest 3.2.2

Zoythrus · « **Reply #3 on:** 6 November 2009, 22:24:11 »

we should totally have "fun" resources!

ok, seriously, i have never had this happen, so could you describe your problem a bit more? does it always say "ro"?

-Archmage- · « **Reply #4 on:** 6 November 2009, 23:49:28 »

Quote

we should totally have "fun" resources!

ok, seriously, i have never had this happen, so could you describe your problem a bit more? does it always say "ro"?

Dude he changed the XML.

Zoythrus · « **Reply #5 on:** 6 November 2009, 23:56:58 »

i had never encountered the error before (and i have messed with all of the XMLs), i just wanted to know how fix it in case someone asks me...(and i thought it was more serious)

-Archmage- · « **Reply #6 on:** 6 November 2009, 23:58:41 »

No Zoythrus, he changed the resource type in one of the resource XMLs.

Zoythrus · « **Reply #7 on:** 7 November 2009, 00:01:08 »

i thought the typo was the "ro" thing...

-Archmage- · « **Reply #8 on:** 7 November 2009, 00:18:00 »

Quote

i thought the typo was the "ro" thing...

What "ro" thing?

Zoythrus · « **Reply #9 on:** 7 November 2009, 02:27:11 »

it says, "converting from string ro ResourceClass" at the bottom of the pic

-Archmage- · « **Reply #10 on:** 7 November 2009, 03:09:29 »

Yea that's the typo.

Zoythrus · « **Reply #11 on:** 7 November 2009, 03:34:22 »

never mind. lock this thread please, we're just going around in circles!

Omega · « **Reply #12 on:** 8 November 2009, 13:32:29 »

It's a completely pointless post. He's pointing out it should say to instead of ro, but he only encountered this error because he put the string 'fun' in the XML attribute that SHOULD contain either tech, tileset, static, or consumable. Not 'fun'.

No real need to change it. No body will ever hopefully see this error unless they screw up BIG in their XML (which means they didn't use my Glest Guide!)

ZaRo · « **Reply #13 on:** 9 November 2009, 09:46:31 »

Quote from: omega on 8 November 2009, 13:32:29

It's a completely pointless post. He's pointing out it should say to instead of ro, but he only encountered this error because he put the string 'fun' in the XML attribute that SHOULD contain either tech, tileset, static, or consumable. Not 'fun'.

No real need to change it. No body will ever hopefully see this error unless they screw up BIG in their XML (which means they didn't use my Glest Guide!)

Oh come on.
Here I come up with a perfectly resonably bug, where to find it and what to do to fix it, and all I'm getting is useless posts on how I found the error. Could we please grow up and fix the bug?

Best regards
Zaro

hailstone · « **Reply #14 on:** 9 November 2009, 11:12:31 »

Thanks for testing ZaRo. This has been fixed in GAE trunk revision 306.

ZaRo · « **Reply #15 on:** 9 November 2009, 11:18:18 »

Quote from: hailstone on 9 November 2009, 11:12:31

Thanks for testing ZaRo. This has been fixed in GAE trunk revision 306.

No. Thank you!

ZaRo

News: