Author Topic: [PARTLY READY TO TEST-3.3.7-dev] All Workers Build, and Stop Getting in the Way!  (Read 2291 times)

modman

  • Guest
This is one of my peeves about Glest in general (although if this is fixed in any version, please notify me).  When I select, say, 5 worker units to build a building, only the first of those five will build it, and the rest will do nothing.  All other commands apply to all units in a selected group except build.  So when I select a group of workers, I want them all to go to the construction place (but not get in the way of the building) and when the building is built, repair the building.

The second, but related improvement is as follows.  When I send a worker to build a building, sometimes there are other units doing their other, independent tasks at the same time (e.g. mining, walking, etc.), and they sometimes get in the way of a building I am trying to build.  This is undesirable.  The way I want it to work is for the unit who is actually building the building to wait at the spot for several seconds, and then build it when the location opens up.  An additional possibility is that after I have given the command to build a building, I want units to avoid walking on that space.
« Last Edit: 29 August 2010, 21:54:36 by titi »

Zoythrus

  • Guest
Re: All Workers Build, and Stop Getting in the Way!
« Reply #1 on: 22 August 2010, 02:18:00 »
agreed.

silnarm

  • GAE Team
  • Behemoth
  • ********
  • Posts: 1,373
    • View Profile
Re: All Workers Build, and Stop Getting in the Way!
« Reply #2 on: 22 August 2010, 02:56:48 »
This is one of my peeves about Glest in general (although if this is fixed in any version, please notify me).
Prepare to be notified!

Quote
When I select, say, 5 worker units to build a building, only the first of those five will build it, and the rest will do nothing.  All other commands apply to all units in a selected group except build.
Notification: fixed in GAE.

Quote
So when I select a group of workers, I want them all to go to the construction place (but not get in the way of the building) and when the building is built, repair the building.
Notification: fixed in GAE, and titi doesn't like auto-repair, so don't expect to see it in MG.

Quote
The second, but related improvement is as follows.  When I send a worker to build a building, sometimes there are other units doing their other, independent tasks at the same time (e.g. mining, walking, etc.), and they sometimes get in the way of a building I am trying to build.  This is undesirable.  The way I want it to work is for the unit who is actually building the building to wait at the spot for several seconds, and then build it when the location opens up.  An additional possibility is that after I have given the command to build a building, I want units to avoid walking on that space.
Notification: fixed in GAE.  If the the site is blocked by moveable units, it will wait indefinitely.
Glest Advanced Engine - Code Monkey

Timeline | Downloads

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: All Workers Build, and Stop Getting in the Way!
« Reply #3 on: 22 August 2010, 13:25:55 »
Yes, most of it somehow works in GAE and yes, I don't like this general kind of autorepair  ;D ( But I think autorepair has nothing to do with this feature)
I'm also annoyed by this build abort, so it will be fixed ( but its noth the first thing on the list )
Same with the multibuild feature.

Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

ultifd

  • Airship
  • ********
  • Posts: 4,443
  • The Glest Video Guy :) The one and only. :P
    • View Profile
    • My Youtube Channel
Re: All Workers Build, and Stop Getting in the Way!
« Reply #4 on: 28 August 2010, 02:34:09 »
Hmm, I already got used to this problem... just select two times usually. Oh well...

 :thumbup: GAE for the fix... but it's kinda a small "problem" to me...so...

and titi doesn't like auto-repair, so don't expect to see it in MG.
Hmm, a feature I miss, but...I can live without it.  :O If it was added maybe it could be optionable... hmm...

EDIT: It is also fixed now in megaglest too, but the additional workers just repair, they don't build I guess. Although sometimes the workers block the "main worker" from building, but that is a small problem...  :thumbup:

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,238
    • View Profile
Re: All Workers Build, and Stop Getting in the Way!
« Reply #5 on: 28 August 2010, 05:28:10 »
Ok this feature is ready for testing in SVN. Multi units can build one unit with a single build command and ALSO units now try to build from the closest angle to the build site that is possible. (this should fix the issue mentioned by ultifd)

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
( I moved these bugreports here, because this was the initial thread... )
I had a MG 3.3.7-dev game on revision 905 with Nebososo today and I was playing egyptians. When building a Sphinx using Multi-build, it happened several times that the workers started building, but then stopped immediately with a 'building can't be placed here' warning. I think this was when I had three workers working on the left and one working on the right of the Sphinx, with the one who initiated it being on the left... I think. It's hard to pinpoint what exactly causes it, so I've uploaded my logs as megaglest_btrunk+r905_d20100830-031557UTC_ptomreyntrunk.tar.gz
« Last Edit: 31 August 2010, 07:50:47 by titi »
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
I played yesterday with tomreyn too and I had similar problems:

I told a group of workers ( about 8 workers ) to build a building. They walked there and the first one started building. Then the others arrived and started to repair. But suddenly I got a message saying "Building cannot be placed here" and they all stop working. This happened several times for mr.

Another issue I spottet is that if the workers are already doing something ( for example repairing another building ) they don't help repairing the new building when I give the command. Only the one who builds walks there. But the repair command must be somehow queued, because when the building is finished they walk over to the other building and help there.
For building such a behaviour is maybe ok, but they also continue their current command if they are for example harvesting gold.

( by the way, toms performance issues are solved, he played with a full debug build before. The new version is much faster now for him! )
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Some(all?) of the above mentioned problems are fixed, but now I have another issue:

For example:
You have 5 workers surrounding a free place. Mark all the workers and tell them to build in this free place. While positioning the building the building is not shown in red, because the place is free, but when you start building some of the workers walk into the place and you get a message:
"Building cannot be placed here"   :(  . Is there any idea how to fix it? Maybe trying the build command again and again if only moving units are blocking it?
or immidialtly put some kind of placeholder in the spot so unit will not walk  through it? Or a combination of both?
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,238
    • View Profile
Ok I have an idea for this. I'll make some code changes and try some things and let you know how it goes.

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
today i tested again ( latest svn revision 940 ) and there is still trouble with this one. While it worked most of the time the following happened again for me:

I selected a group of workers and told them to build  a building. They walked over and the first one starts to build. Then the others repair, but suddenly all the repair units stand up and didn't do anthing , while the builder itself was still building.
« Last Edit: 4 September 2010, 17:20:19 by titi »
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,238
    • View Profile
Checked in another update in SVN, please test and lets see if the problem is fixed.