[fixed] Bug: Switched user names

[tomreyn]

I was just playing a game with ultifd on r939 yesterday. While I logged onto his game server as 'tomreyntrunk', when I chatted in the lobby and in game, the game would report that I was 'AI1' (first CPU player). This incorrect output could be observed on both client and server. I created a log file of this game which I uploaded to the common location. Its name is megaglest_btrunk+r939_d20100904-042002UTC_ptomreyntrunk.tar.gz

[tomreyn]

This happened again today. Here's the client log for the switched player name: megaglest_btrunk+r950_d20100907-233125UTC_ptomreyntrunk_tswitched_player_name.tar.gz

[ultifd]

This happened again today, using head (r972), weird.
This time with Nebososo.

(click to show/hide)

This happened again, this time with SVN head. The client had the same nickname as the server...

(click to show/hide)

[tomreyn]

This should be fixed in beta3, if it's not, please respond to this thread and I'll remove the [fixed] tag again.

[ultifd]

I believe it is fixed.
But if it occurs to me again somehow, I'll tell softcoder then I'll post here...or vice versa.