[fixed] Bug: Unprovoked out-of-synch

[tomreyn]

Ulti and I just got disconnected from a six humans two CPU/bots game after the two of us died (but not immediately afterwards). The error message on screen looked like 'out of synch' but was badly positioned (lower part of my screen) and cut off. The visible text was also not easily readable. FPS of both Ulti and me were not low, but rather normal.

<titi_linux> I also saw this when we were hunting for out of syncs some time ago
<softcoder> fog of war lifted is bad for network
<softcoder> cause you may still have units
<softcoder> and they will see more on your end than the other players ends
<softcoder> and out of synch
<titi_linux> oh thats why?!
<softcoder> i think so
<softcoder> the unit can still do things
<titi_linux> so its not good it server has lost ....
<softcoder> right
<titi_linux> if server has lost
<softcoder> need to think about that one carefully

Actually I think I had no units left but I assume the logs can tell: megaglest_v3.3.7-beta3-GNUC_d20100929-225145UTC_ptomreyn_toutofsync.tar.gz is avaiable at the usual location.

[ultifd]

And more...

Code: [Select]

<softcoder> i think the fix for fog of war is to do it ONLY for the player dead
<softcoder> I think it turn it on for all players
<titi_linux> ?
<titi_linux> what is turned on for all players?
<titi_linux> I think its not only his own unit which make trouble
<titi_linux> also others units run away maybe !
<titi_linux> because on his computer they don't have fog of war!
<softcoder> yes
<softcoder> so i think the fix is likely to do exactly the same i did for the "observer" faction
<softcoder> I can do something similar
<softcoder> make the player look like an observer
<softcoder> that makes sense
<titi_linux> oh so fog of war is just not rendered in this case right?
<softcoder> it is only always enabled for observers
<softcoder> I will use the same logic when a player is dead

[softcoder]

I have modified the code and checked into svn. Feel free to test out svn head.