Fixed: r1089: Segfault in "Shared::Graphics::TextureManager::end"

[tomreyn]

And another segmentation fault in r1089:

Code: [Select]

Program terminated with signal 6, Aborted.
#0  0x00007fcdce108a75 in raise () from /lib/libc.so.6
#0  0x00007fcdce108a75 in raise () from /lib/libc.so.6
#1  0x00007fcdce10c5c0 in abort () from /lib/libc.so.6
#2  0x00007fcdce1424fb in ?? () from /lib/libc.so.6
#3  0x00007fcdce14c5b6 in ?? () from /lib/libc.so.6
#4  0x00007fcdce14ca61 in ?? () from /lib/libc.so.6
#5  0x00007fcdce14f460 in ?? () from /lib/libc.so.6
#6  0x00007fcdce152e83 in free () from /lib/libc.so.6
#7  0x00000000005e7d26 in ~Pixmap2D (this=0x2b8d118,
    __in_chrg=<value optimised out>)
    at shared_lib/sources/graphics/pixmap.cpp:467
#8  0x00000000005f7788 in ~Texture2D (this=0x2b8d0f0,
    __in_chrg=<value optimised out>)
    at shared_lib/sources/../include/graphics/texture.h:104
#9  ~Texture2DGl (this=0x2b8d0f0, __in_chrg=<value optimised out>)
    at shared_lib/sources/../include/graphics/gl/texture_gl.h:47
#10 0x00000000005e553a in Shared::Graphics::TextureManager::end (
    this=0x1ca0490) at shared_lib/sources/graphics/texture_manager.cpp:95
#11 0x0000000000472944 in Glest::Game::Renderer::endGame (this=0x8901a0)
    at glest_game/graphics/renderer.cpp:397
#12 0x000000000044631d in ~Game (this=0x2eeb5d0,
    __in_chrg=<value optimised out>) at glest_game/game/game.cpp:129
#13 0x000000000049e422 in Glest::Game::Program::setState (this=0x1ca0750,
    programState=0x1000b6a0, cleanupOldState=true)
    at glest_game/main/program.cpp:395
#14 0x000000000043f750 in Glest::Game::Game::exitGameState (program=0x1ca0750,
    endStats=...) at glest_game/game/game.cpp:1336
#15 0x000000000049d5f6 in Glest::Game::Program::loopWorker (this=0x1ca0750)
    at glest_game/main/program.cpp:255
#16 0x000000000049a625 in Glest::Game::glestMain (argc=1, argv=0x7fff5414bd88)
    at glest_game/main/main.cpp:950
#17 0x00007fcdce0f3c4d in __libc_start_main () from /lib/libc.so.6
#18 0x000000000040ad09 in _start ()

The corresponding log file dump is megaglest_btrunk+r1089_d20101011-031113UTC_ptomreyntrunk_tsegfault.tar.gz

I hope these issues are actually all the same. I canhardly imagine that so many new bugs were introduced lately... The game seemed and I'd even claim it _was_ pretty stable before 3.3.7 was released.

[softcoder]

Not sure how you built your binary, but please do a jam clean and jam to rebuild a clean build. Since changing the stuff in gl_font I have a feeling your binary is corrupt since it did only a partial recompile with that file change. Doing a full rebuild let me know if you still get all theses errors reported?

Thanks

[tomreyn]

I believe I did a full rebuild before I started testing. I ran 'jam clean; ./configure; jam' in mk/linux/. Note that I did make changes to my glestuser.ini during some of those tests, because using the glestuser.ini which worked fine with 3.3.7 did seem to cause font issues with r1089: the text vanished completely in one case (the one where a lot of trees at the bottom of my screen vanished, too), just as Nebososo had encountered it yesterday.

[titi]

there definitly must be something very wrong with r1089 and its definitly not in 3.3.7 release version!
I also crash quite quick:

Code: [Select]

#0  Shared::Graphics::Gl::ModelRendererGl::render (this=0x83b81f8, model=0x0) at shared_lib/sources/graphics/gl/model_renderer_gl.cpp:106
#1  0x080d7a87 in Glest::Game::Renderer::renderObjectsFast (this=0x8351760) at glest_game/graphics/renderer.cpp:3175
#2  0x080d8641 in Glest::Game::Renderer::renderShadowsToTexture (this=0x8351760, renderFps=166) at glest_game/graphics/renderer.cpp:2694
#3  0x080a3cc7 in Glest::Game::Game::render3d (this=0x924adb8) at glest_game/game/game.cpp:1373
#4  0x080aa676 in Glest::Game::Game::renderWorker (this=0x924adb8) at glest_game/game/game.cpp:755
#5  0x080fd030 in Glest::Game::Program::loopWorker (this=0x83847b8) at glest_game/main/program.cpp:266
#6  0x080f6d7e in Glest::Game::glestMain (argc=1, argv=0xbf8cba54) at glest_game/main/main.cpp:950
#7  0x080f8562 in main (argc=1, argv=0xbf8cba54) at glest_game/main/main.cpp:985

But I have no idea what might cause it.

[softcoder]

All fixed and svn is stable again.