Author Topic: Bug: one worker fails to build on queued build  (Read 1758 times)

tomreyn

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Bug: one worker fails to build on queued build
« on: 23 December 2010, 01:14:43 »
<tomreyn> if you make one worker build a building, then queue another build job for this one and another worker (who is currently idle) then only one of them (not sure which one) will build the second building,
<tomreyn> the other one will just stand around near the first building
<tomreyn> i have not tested whether this is reproducible but i think it is, since it happened this way to me several times
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: Bug: one worker fails to build on queued build
« Reply #1 on: 24 December 2010, 00:45:05 »
What would you expect would happen?

Startcondition:
One worker(a) is currently building a building. Another is ideling. Now these two ( as a group ) get a command queued saying build building xy at point Z.
I expect the ideling worker walk over there to start building. The other one continues building his former building.

And then?
Do you expect the builder (a)  to walk over there and try to help repair the building when hi former build command is done?
 
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

John.d.h

  • Moderator
  • Airship
  • ********
  • Posts: 3,757
  • I have to go now. My planet needs me.
    • View Profile
Re: Bug: one worker fails to build on queued build
« Reply #2 on: 24 December 2010, 00:52:02 »
And then?
Do you expect the builder (a)  to walk over there and try to help repair the building when hi former build command is done?
That's what I would expect to happen.  Technically he's queued to build it, but since it's already being built, having him repair it makes sense to me.

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: Bug: one worker fails to build on queued build
« Reply #3 on: 26 December 2010, 04:50:45 »
Ok, I think this bug is fixed in svn head. The problem was that all units tried to "best" cell to build the unit. if the 'best' cell was occupied the unit did not check other cells.

tomreyn

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: Bug: one worker fails to build on queued build
« Reply #4 on: 30 December 2010, 03:47:44 »
Hmm, I'm not sure I understand what was fixed but the issue I tried to describe is still present in r1386, most likely due to my imperfect description. I'll try to improve on this:

This is how you trigger this issue:
1. Worker A builds building 1
2. Worker B joins worker A in building 1 (by repairing)
3. User marks both workers and assigns a queued build job for both to build building 2.
4. Once both workers finished building 1, worker B starts building 2, while worker A remains standing next to building 1.

Expected result:
After completing building 1, both workers A and B start to build/repair building 2.

Actual result:
After completing the first building, only one of the two workers starts to build building 2.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

ElimiNator

  • Airship
  • ********
  • Posts: 3,391
  • The MegaGlest Moder.
    • View Profile
Re: Bug: one worker fails to build on queued build
« Reply #5 on: 30 December 2010, 06:54:21 »
After completing the first building, only one of the two workers starts to build building 2.
Yah, it happens for me too.
Get the Vbros': Packs 1, 2, 3, 4, and 5!

tomreyn

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: Bug: one worker fails to build on queued build
« Reply #6 on: 8 January 2011, 17:08:00 »
This is something I'd like to see fixed for the next release, yet, if possible.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: Bug: one worker fails to build on queued build
« Reply #7 on: 9 January 2011, 23:33:56 »
Should be fixed in svn now

tomreyn

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: Bug: one worker fails to build on queued build
« Reply #8 on: 10 January 2011, 10:42:44 »
Thanks, this is now fixed in many but not all cases.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·