[FIXED] Bug: Quit message displays in language of quitting user

[tomreyn]

This affects both 3.4.0 and r1765:
If a user quits, then a quit message is displayed to the remaining user in the language the quitting user has setup. So if the user who is leaving has setup her game language to be portuguese, but the other users have different languages setup, such as english and french, the other users will still get to see this message about the user quitting:

Code: [Select]

Username: Decidiu sair do jogo!
It seems that some client messages are just passed through as localized strings, not as placeholders which then get translated by each receiving users' game. This would also explain why sometimes you get to see something like ???QuitGame??? when a user quits who doesn't have up to date language files (but you do have up to date ones).

[Omega]

Oh nein!

... Uh, I mean "Oh no!"

It should be passing as the variable, shouldn't it? Such as "StartingToUpgrade" instead of "Starting to upgrade" (or "Starte Verbesserungsvorgang" [Hmm, that is a very long word... Poor German players...]) and then be translated based on the players language file.

[titi]

either this or more simple just use english for these cases and skip the translation.

[tomreyn]

This bug is still present in 3.5.0 beta1.

[softcoder]

Should hopefully be fixed now with the latest svn version, each player will see system generated network messages in their own language.