[Fixed] Selecting multiple units of same type by double-clicking often fails

[tomreyn]

When I double-click a unit, the expected behaviour is that in addition to this unit, neighbouring units of the same type are selected, too. However, this fails more often than not, resulting in either no unit at all or just the unit below the mouse pointer being selected. It is actually very rare that the expected behaviour works.

[hailstone]

It works every time for me. What I think could be happening is that you're trying to click a moving unit and you move the mouse as you double click to keep it over the unit but it activates the selection box instead. Is this the case?

[tomreyn]

No, the unit I'm double-clicking on is not moving.

I recorded a video to display what I'm trying to do and how it fails. It also shows how the shadows behave strangely.
This video is only 1.2 MB. It is encoded with the OGG Theora video and the OGG Vorbis audio codec, Firefox and Chrome should be able to play it back as part of their HTML5 video tag support.

I use a relatively new open source ATI 3D video drivers (gallium 0.4) on Ubuntu 11.04 (still a beta, but this should not matter in this case). So this might be an explanation if I'm the only one this is happening to. It might be good to check with others to get an idea of whether or not I'm a special case there.

[silnarm]

looks like they are getting selected, then its picking again and re-selecting just the one.

This may be another symptom of the missing mouseUp() events that John used to crash the drop-lists on the new game menu, will hopefully get a chance to investigate on linux tonight.

[hailstone]

I noticed in sdl/window.cpp Window::handleMouseDown, eventMouseDown and eventMouseDoubleClick are called together but in the Windows version they aren't.

[Yggdrasil]

Yep, hailstone hit the nail. Removing eventMouseDown fixed it for me.

[tomreyn]

Yes, very nice. This fix in f9192dd490e836bd1b5783a839228937434f32a3 does it for me.