[Fixed] Crash when closing "Human" player slot in a single player game

[tomreyn]

This happens when, while setting up a custom game with only on player in it - a "Human") -, you move the "Human" player to slot 3 (or any other slot than the first one), then close this slot:

Code: [Select]

glestadv: [redacted]/source/game/menu/menu_state_new_game.cpp:373: int Glest::Menu::getLowestFreeColourIndex(Glest::Widgets::PlayerSlotWidget**): Assertion `(slots[i]->getControlType() != ControlType::CLOSED) && "Closed slot has colour set."' failed.

Crash
Version: Advanced Engine git-master
Time: Mon Apr 18 18:22:49 2011
Description: SIGABRT:
Address: 0x3e8000040e8
Backtrace:
./build/source/game/glestadv(_ZN6Shared8Platform24PlatformExceptionHandler7handlerEiP7siginfoPv+0xf7) [0x7167e7]
/lib/x86_64-linux-gnu/libpthread.so.0(+0xfc60) [0x7f5e75c5ec60]
/lib/x86_64-linux-gnu/libc.so.6(gsignal+0x35) [0x7f5e73d4cd05]
/lib/x86_64-linux-gnu/libc.so.6(abort+0x186) [0x7f5e73d50ab6]
/lib/x86_64-linux-gnu/libc.so.6(__assert_fail+0xf5) [0x7f5e73d457c5]
./build/source/game/glestadv() [0x598e6d]
./build/source/game/glestadv(_ZN5Glest4Menu16MenuStateNewGame15onChangeControlEPNS_7Widgets6WidgetE+0x168) [0x59a788]
./build/source/game/glestadv(_ZN5Glest7Widgets16PlayerSlotWidget16onControlChangedEPNS0_6WidgetE+0x2d) [0x6af7ad]
./build/source/game/glestadv(_ZN5Glest7Widgets8DropList11setSelectedEi+0xbd) [0x6b157d]
./build/source/game/glestadv(_ZN5Glest7Widgets8DropList15onSelectionMadeEPNS0_6WidgetE+0x37) [0x6b1cf7]
./build/source/game/glestadv(_ZN5Glest7Widgets7ListBox10onSelectedEPNS0_6WidgetE+0xad) [0x6b0a5d]
./build/source/game/glestadv(_ZN5Glest7Widgets11ListBoxItem7mouseUpEN6Shared8Platform11MouseButtonENS2_4Math4Vec2IiEE+0x75) [0x6b1035]
./build/source/game/glestadv(_ZN5Glest7Widgets12WidgetWindow12eventMouseUpEiiN6Shared8Platform11MouseButtonE+0x3fc) [0x693f9c]
./build/source/game/glestadv(_ZN6Shared8Platform6Window11handleEventEv+0x2be) [0x7157ee]
./build/source/game/glestadv(_ZN5Glest4Main7Program4loopEv+0x4a) [0x57ceea]
./build/source/game/glestadv(_ZN5Glest4Main9glestMainEiPPc+0x323) [0x579913]
./build/source/game/glestadv(main+0x35) [0x579ef5]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xff) [0x7f5e73d37eff]
./build/source/game/glestadv() [0x4c52e9]


[tomreyn]

This is now ticket #333.