[not BUG] v3.5.1(+), linux 64-bit: $COMMONDATAPATH breaks "--autostart-lastgame"

[sojourner]

Please take a look at this traceback:

Code: [Select]

mk/linux/megaglest.bin --ini-path=mk/linux/ --data-path=mk/linux/  --autostart-lastgame
v3.5.1-dev-GNUC: 40502 [64bit]-May  4 2011 00:55:04, SVN: [Rev: 2208M], [STREFLOP]
[2011-05-14 16:22:38] *ERROR* In [/home/eye/tmp/megaglest/source/glest_game/types/unit_type.cpp::load Line: 485] Error [The string "$COMMONDATAPATH/sounds/ab_attack1.wav" contains a character that is not allowed: "$"
For portability reasons the only allowed characters in this field are: abcdefghijklmnopqrstuvwxyz1234567890._-/]
[2011-05-14 16:22:38] *ERROR* In [/home/eye/tmp/megaglest/source/glest_game/types/faction_type.cpp::load Line: 96] Error [Error loading UnitType: mk/linux/techs/megapack/factions/egypt/units/air_pyramid/air_pyramid.xml
The string "$COMMONDATAPATH/sounds/ab_attack1.wav" contains a character that is not allowed: "$"
For portability reasons the only allowed characters in this field are: abcdefghijklmnopqrstuvwxyz1234567890._-/]
[2011-05-14 16:22:38] *ERROR* In [/home/eye/tmp/megaglest/source/glest_game/types/tech_tree.cpp::load Line: 187] Error [Error loading units: mk/linux/techs/megapack/factions/egypt/
Error loading UnitType: mk/linux/techs/megapack/factions/egypt/units/air_pyramid/air_pyramid.xml
The string "$COMMONDATAPATH/sounds/ab_attack1.wav" contains a character that is not allowed: "$"
For portability reasons the only allowed characters in this field are: abcdefghijklmnopqrstuvwxyz1234567890._-/]
[2011-05-14 16:22:38] *ERROR* In [/home/eye/tmp/megaglest/source/glest_game/main/program.cpp::setState Line: 449] Error [Error loading Faction Types: mk/linux/techs/megapack/
Error loading units: mk/linux/techs/megapack/factions/egypt/
Error loading UnitType: mk/linux/techs/megapack/factions/egypt/units/air_pyramid/air_pyramid.xml
The string "$COMMONDATAPATH/sounds/ab_attack1.wav" contains a character that is not allowed: "$"
For portability reasons the only allowed characters in this field are: abcdefghijklmnopqrstuvwxyz1234567890._-/]
terminate called after throwing an instance of 'std::runtime_error'
  what():  In [/home/eye/tmp/megaglest/source/shared_lib/sources/platform/sdl/thread.cpp::v Line: 124] mutex == NULL refCount = 1 owner [/home/eye/tmp/megaglest/source/shared_lib/sources/platform/common/base_thread.cpp_77]

Edit: Rewrapped in a code block for better readability.

[tomreyn]

The version you are using is somewhat old (revision 2208). MG 3.5.1 is revision 2252. Can you please try whether this is still an issue with the latest release? I cannot make a statement as to whether or not it is, but I do know a lot has changed in code related to this between these revisions.

[sojourner]

svn update showed the version at 2254 (no files were updated)
svn diff showed nothing.
I had compiled with ./build-mg.sh.
I was playing till now and everything was fine until I tried the --autostart-lastgame option
After that in the game menu, "reload last settings"

now...
I deleted the build directory and created it once more.
ran ./build-mg.sh
works fine when I use "reload last settings" in the game menu
works fine when I pass "--autostart-lastgame"

Ah! here is the problem then: I used to start the game from command line using the megaglest.bin (from the shell history). Apparently that file still remains in mk/linux. When I copy paste the output of ./build-mg.sh (which tells me to run megaglest and not megaglest.bin) it works fine.  I had tried a make clean, but I guess that would not have removed a file built by the earlier cmake settings...

I should learn the svn procedure to remove non-repository files from the directory tree.