Options Menu

[hailstone]

Are there any particular options that people want, that are already set with glestadv.ini and isn't already, in the options menu? I know resolution is one.

------------------------------------

Progress:
RenderShadowTextureSize (Partially added, needs to be updated with resolution)
'Resolution' <- DisplayHeight, DisplayWidth, DisplayRefreshFrequency (Silnarm added Windows implemenation, Yggdrasil added SDL implementation, needs testing)
CameraInvertXAxis (Added, needs testing)
CameraInvertYAxis (Added, needs testing)
GsAutoRepairEnabled (Added, needs testing)
GsAutoReturnEnabled (Added, needs testing)
RenderEnableBumpMapping (Added, needs testing)
RenderEnableSpecMapping (Added, needs testing)
DisplayWindowed (Added by silnarm, needs testing)
RenderShadowFrameSkip (Added, needs testing)
UiConsoleMaxLines (Added, needs testing)
UiFocusArrows (Added, needs testing)
UiScrollSpeed (Added, needs testing)

Controls keymap (Added by silnarm, needs testing)

Problems:
- I think I've messed up the anchoring again. (fixed)
- Toggle fullscreen doesn't seem to work properly on Windows. (fixed by silnarm)
- Lang strings need to be added for the new options. (added for English)
- Might need to rearrange the widgets to fit the text better.

[Omega]

I think most of the options available that a standard user could have at least some reason to change, should be there. Obviously, space is not an issue, so there's no harm in putting EVERY option in (though some might be put into an "advanced" category, meant only for people who know what they're doing). It would also be nice if we could have tooltips for all the options (use the data available on the wiki: https://docs.megaglest.org/GAE/INI)

CameraFov
CameraInvertXAxis
CameraInvertYAxis
CameraMaxDistance
CameraMaxYaw
CameraMinDistance
CameraMinYaw
DisplayHeight
DisplayRefreshFrequency
DisplayWidth
DisplayWindowed
GsAutoRepairEnabled
GsAutoReturnEnabled
GsDayTime
NetConsistencyChecks
NetPlayerName
RenderColorBits
RenderDepthBits
RenderDistanceMax
RenderDistanceMin
RenderFilter
RenderFilterMaxAnisotropy
RenderFogOfWarSmoothing
RenderFogOfWarSmoothingFrameSkip
RenderFontScaler
RenderFov
RenderFpsMax
RenderInterpolateWithSIMD
RenderLightsMax
RenderShadowAlpha
RenderShadowFrameSkip
RenderShadowTextureSize
RenderShadows
RenderStencilBits
RenderTextures3D
SoundStaticBuffers
SoundStreamingBuffers
SoundVolumeAmbient
SoundVolumeFx
SoundVolumeMusic
UiConsoleMaxLines
UiConsoleTimeout
UiFocusArrows
UiLocale
UiPhotoMode
UiScrollSpeed

This above is pretty much all the stuff that should need to be set by users, to my knowledge. It filters out INI settings that should never be touched (eg: world refresh rate, as changing this will break some timers), setting that only have a single option (eg: graphics factory, which must be OpenGL), or settings that are practically never used (eg: first time, which is only used to tell the engine to try and guess the settings for the user, which will overwrite the user's own settings, and would generally be undesired). Obviously, those things can still be changed in the INI and will be documented on the wiki (tip: new INI entries should be added to the wiki the moment they are added to the git master).

[hailstone]

Space is always an issue and adding every option increases the workload without much benefit. I want to focus on the options that will give the most benefit to users.

Filtering out the ones already implemented and some that don't need to be edited by players:
CameraInvertXAxis
CameraInvertYAxis
DisplayRefreshFrequency
DisplayWindowed
GsAutoRepairEnabled
GsAutoReturnEnabled
RenderShadowFrameSkip
RenderShadowTextureSize
RenderEnableBumpMapping
RenderEnableSpecMapping
'Resolution' <- DisplayHeight, DisplayWidth
UiConsoleMaxLines
UiFocusArrows
UiScrollSpeed

'Shadow Quality' could group a few but I'll leave them seperate for now.

I wrote a script that generates the ini descriptions for the wiki. So when one is added the description can be added right next to it at the same time.

[hailstone]

This is mostly completed as of commit 74b2d0b8.. . Please let me know if there are any bugs.

[Omega]

This is mostly completed as of commit 74b2d0b8.. . Please let me know if there are any bugs.

Excellent. I'll have to take a look when I get time.

[silnarm]

I stuck the keymap widget on the controls tab, and I've removed the network tab for now, seeing as we have nothing to put on it for the time being.

[ultifd]

Nice job, with this finished it finally fixed my resolution problem! 
Don't forget to fix the language file, at the controls tab there is: ???HotKeys???
Also for the audio tab, do you think there could be a percentage or something like that? If not, it's ok.

[John.d.h]

Don't forget to fix the language file, at the controls tab there is: ???HotKeys???

Feel free to remind me in a couple days if any language keys are still missing.  I'm a bit occupied with getting myself out of the ghetto (finally! ).

[silnarm]

Nice job, with this finished it finally fixed my resolution problem! 

Yeah, this was probably fixed a while ago, bug from original Glest code, Windows wasn't being informed that the resolution change was of a temporary nature.

Don't forget to fix the language file, at the controls tab there is: ???HotKeys???

Sorry, I get lazy... if it doesn't show up in the solution explorer, it doesn't exist! 
Added.

Also for the audio tab, do you think there could be a percentage or something like that? If not, it's ok.

Could do I guess... just have to fix those rounding problems so Omega doesn't complain about his 80 becoming 79.

Don't forget to fix the language file, at the controls tab there is: ???HotKeys???

Feel free to remind me in a couple days if any language keys are still missing.  I'm a bit occupied with getting myself out of the ghetto (finally! ).

We programmer types should really be adding new keys to the English lang file when we use them in code, and mostly do... except me, perhaps.

Good luck with your move, hope all goes smoothly.

[hailstone]

Some of the text doesn't fit in the space properly so I was thinking instead of having two panels on a tab page have one that scrolls and possibly have anchor link type buttons that moves the scroller to the correspoding heading when pressed. That would also leave some space should we implement option descriptions.

Something like this:

[Omega]

I like it, but I think we should just have one "sidebar" (shown in white on that image).

[hailstone]

The white would be the model background when done properly. It's only white because I moved the section in paint.

[Psychedelic_hands]

Looks good, can't wait to play around with all the options.

[hailstone]

Here's a comparison of the in-game options layout with a better example of what the final result will look like. The top two are the old layout and the bottom one is new.

[Yggdrasil]

I like the new layout. Looks much better and well arranged.

[Omega]

Wow, looks great. How many of the settings are available in this menu? Just the ones you mentioned in your post above, or more than that?

[hailstone]

I haven't changed the settings just how they are arranged.

I've committed the changes. There's a bug with the scrollbar where it resets if you move the options window in-game but I'm not sure how to fix it. It's not a big problem though.

[silnarm]

Looks really nice 

Might make the 'sections' foldable one day...
Fixed the scrollbar thing for OptionPanels (though I noticed the Keymap widget does it too...)