Author Topic: [fixed] svn-2453 unit particle has bad shape  (Read 701 times)

will

  • Golem
  • ******
  • Posts: 783
    • View Profile
[fixed] svn-2453 unit particle has bad shape
« on: 7 July 2011, 11:05:10 »
an error occurs trying to create a particle because it has a bad shape here:
https://github.com/williame/megaglest/blob/master/source/shared_lib/sources/graphics/particle.cpp#L672

However, shape is always initialized; I've stared at the code; how can a unit be created without passing through the unit particle system type setValues()?
https://github.com/williame/megaglest/blob/master/source/glest_game/graphics/unit_particle_type.cpp#L50

(click to show/hide)

suggestion: UnitParticleSystem::UnitParticleSystem() to initialise shape to sLinear.

however: I'd still like to be shown how we have unit particles that aren't going via the setValues() bit.  Have I missed tileset particles or something?
« Last Edit: 7 July 2011, 11:11:37 by will »

Coldfusionstorm

  • Golem
  • ******
  • Posts: 868
    • View Profile
Re: [bug] svn-2453 unit particle has bad shape
« Reply #1 on: 7 July 2011, 11:42:32 »
Just checking in to say yes ive seen this.
WiP Game developer.
I do danish translations.
"i break stuff"

will

  • Golem
  • ******
  • Posts: 783
    • View Profile
Re: [bug] svn-2453 unit particle has bad shape
« Reply #2 on: 7 July 2011, 11:44:59 »
Update.  unit.cpp#2490 ?


Coldfusionstorm

  • Golem
  • ******
  • Posts: 868
    • View Profile
Re: [bug] svn-2453 unit particle has bad shape
« Reply #3 on: 7 July 2011, 11:50:46 »
No, that is not the error i get i get a slightly different one.

(click to show/hide)
WiP Game developer.
I do danish translations.
"i break stuff"

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: [bug] svn-2453 unit particle has bad shape
« Reply #4 on: 8 July 2011, 16:46:18 »
Should be fixed in svn