[fixed] PEBKAC with --use-video-settings

[tomreyn]

I tried to use the --use-video-settings command line option to make the game start up in full screen.

Actually I did not want to modify the resolution, but the --help output says I have to specify width and height, so I used:

Code: [Select]

--use-video-settings=800x600x*xtrue
Unfortunately the game exits with an error (segfaults) there saying: Error converting from string to int.

When I use this instead...

Code: [Select]

--use-video-settings=800x600x*x1...then there is no error but the game does not switch to full screen nevertheless.

[softcoder]

According to the help is says:

Code: [Select]

--use-video-settings=x override video settings.
                      Where x is a string with the following format:
                      widthxheightxcolorbitsxdepthbitsxfullscreen
                      where * indicates not to replace the default value for the parameter
                      fullscreen has possible values of true, false, 1 or 0
                      and only the width and height parameters are required (the others are optional)
                      example: ../mk/linux/megaglest --use-video-settings=1024x768x*x*
                      same result for: ../mk/linux/megaglest --use-video-settings=1024x768

So in fact the place you inserted true was depthbits which is a numeric value. Please pass along suggestions to improve this commandline option so that it is easier to use and more clear and I'll update it.

Thanks

[tomreyn]

Oh, thanks for helping me read. It works fine for me when I do it as it says in the help.

Indeed, the current usage feels a bit crude. Would it be possible to have separate options for (most of) these settings, i.e.:

Code: [Select]

--resolution 800x600
--colorbits 32
--depthbits 24
--fullscreen
--windowed

Generally, I'd recommend trying to try to stay compatible with getopt long options (including the short POSIX.2 style ones) parsing works:

https://www.gnu.org/s/hello/manual/libc/Getopt-Long-Options.html#Getopt-Long-Options

https://www.gnu.org/prep/standards/html_node/Command_002dLine-Interfaces.html#Command_002dLine-Interfaces

[softcoder]

Done in svn (replaced with multiple parameters)