upgrades required to morph

[Mr War]

hi, can't figure out the correct syntax for requiring an upgrade before allowing a unit to morph into another. Here's what I have, which is incorrect ..

<command>                                    
         <type value="morph"/>                                 
         <name value="transform_to_autoblaster"/>                                 
         <image path="../autoblaster/images/unit_archer.bmp"/>                                 
         <unit-requirements/>                                 
         <upgrade-requirements>
            <upgrade name="transformational_mechanics"/>
            <upgrade discount="0"/>
         <upgrade-requirements/>
                                 
         <morph-skill value="convert_to_aaa"/>                                 
         <morph-unit name= "autoblaster"/>                                 
         <discount value="0"/>                                 
      </command>

[John.d.h]

Change <upgrade-requirements/> to </upgrade-requirements>.  The / at the end means that the tag is both starting and ending at the same spot (i.e. a tag that doesn't need additional details), while the / at the beginning means "You know that tag we opened earlier?  Here is where it ends."  I also have no idea what the <upgrade discount> thing is.  That doesn't look familiar to me, but maybe it's a MegaGlest thing.

[will]

I think this demonstrates a bug in the XML parsing in MG: that if an error is encountered parsing the XML - its badly formed - no error is raised, and instead the rest of the file is ignored.

[Mr War]

doh! thanks man, that solved it

[titi]

upgrade discount is an original glest feature. Look at magics initiate. he needs 2 energy to morph and gets one back after morphing.

[John.d.h]

upgrade discount is an original glest feature. Look at magics initiate. he needs 2 energy to morph and gets one back after morphing.

Isn't that what the <discount value=""/> does?

[softcoder]

Will, I am pretty sure badly formatted XML is shown when loading (at least from the times we've had bad xml it throws errors).

[will]

I know for a fact that, in MG, on my ubuntu box, badly formed XML is a silent truncation.

[tomreyn]

Silent...where? Were you running in a terminal window so you could follow what was written to standard (error) output?

[Omega]

upgrade discount is an original glest feature. Look at magics initiate. he needs 2 energy to morph and gets one back after morphing.

Actually, there's no such thing as upgrade discount. There is <discount value=""/> as John mentioned, which returns resources AFTER the morphing is complete, as a percentage. In GAE, there's also <cost-modifier value=""/> which does the same thing, but takes the resource cost off BEFORE (so you don't need the full resources to begin the morph). However, it is not a child of <upgrade-requirements />.

As a future note, you can find the correct syntax of EVERY XML tag in Glest and the majority of GAE/MG tags on the wiki, with syntax highlighting and full explanations.

Command XMLs such as for morph are here: https://docs.megaglest.org/XML/Commands

And a full list here: https://docs.megaglest.org/XMLs