Author Topic: [FIXED] Worker is able to repair all buildings when he should not be  (Read 1365 times)

lazyanttu

  • Guest
Well, I tested if I had different workers for different resources/buildings. Everything else went well, but even when I specified which buildings each worker is able to build and repair, they were still able to repair all buildings. Am I doing something wrong or is it a bug? :look:

Code: [Select]
    <command>
      <type value="repair"/>
      <name value="repair"/>
      <image path="images/worker_repair.bmp"/>
      <unit-requirements/>
      <upgrade-requirements/>
      <move-skill value="move_skill"/>
      <repair-skill value="repair_skill"/>
      <repaired-units>
        <unit name="arcology"/>
        <unit name="research_center"/>
        <unit name="guard_tower"/>
        <unit name="heavy_turret"/>
        <unit name="mds"/>
<unit name="dense_arcology"/>
      </repaired-units>
« Last Edit: 10 September 2011, 23:20:48 by Omega »

hailstone

  • Local Moderator
  • Battle Machine
  • ********
  • Posts: 1,568
    • View Profile
Re: Worker is able to repair all buildings when he should not be
« Reply #1 on: 10 September 2011, 05:46:13 »
Thanks for reporting. It's a bug. The list was never checked when issuing the repair command. I've committed a fix. (commit 5ac207b8cc..)

Please change the topic title to include fixed if you can confirm the fix worked.
Glest Advanced Engine - Admin/Programmer
https://sourceforge.net/projects/glestae/

lazyanttu

  • Guest
Re: Worker is able to repair all buildings when he should not be
« Reply #2 on: 10 September 2011, 17:57:52 »
Where I can get the fix?

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: Worker is able to repair all buildings when he should not be
« Reply #3 on: 10 September 2011, 23:22:24 »
Thanks for reporting. It's a bug. The list was never checked when issuing the repair command. I've committed a fix. (commit 5ac207b8cc..)

Please change the topic title to include fixed if you can confirm the fix worked.
Nice work. On a side note, you have moderation abilities, you are able to change the titles of threads if you wish. I also moved this to the bugged reports category (with the proper title).
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

lazyanttu

  • Guest
Re: [FIXED] Worker is able to repair all buildings when he should not be
« Reply #4 on: 10 September 2011, 23:46:07 »
Sorry for me repeating my question, but where can I get/test the new fix? Is the installer updated or must I download it from somewhere or...?
Well, I don't know much about all of this, and my skills are limited to just modelling and XML scripting (and I'm not doing either of them well), but I keep learning these things, so I hope that I'm not annoying people with my lack of skills :-X.

Yggdrasil

  • Local Moderator
  • Ornithopter
  • ********
  • Posts: 408
    • View Profile
Re: [FIXED] Worker is able to repair all buildings when he should not be
« Reply #5 on: 11 September 2011, 15:21:12 »
It's in our code repository. You have to compile it on your own or wait for the next release.

some instructions:
http://sourceforge.net/apps/trac/glestae/wiki/CompileGuide

hailstone

  • Local Moderator
  • Battle Machine
  • ********
  • Posts: 1,568
    • View Profile
Re: Worker is able to repair all buildings when he should not be
« Reply #6 on: 14 September 2011, 12:15:44 »
Thanks for reporting. It's a bug. The list was never checked when issuing the repair command. I've committed a fix. (commit 5ac207b8cc..)

Please change the topic title to include fixed if you can confirm the fix worked.
Nice work. On a side note, you have moderation abilities, you are able to change the titles of threads if you wish. I also moved this to the bugged reports category (with the proper title).
Thanks Omega. I was more after someone else to test the changes. Hopefully it was tested before "fixed" was added.
Glest Advanced Engine - Admin/Programmer
https://sourceforge.net/projects/glestae/

 

anything