Author Topic: [fixed] - 3.5.3 beta1, Magic Faction, Golem can finish building himself  (Read 2233 times)

TotalNoob

  • Guest
Hi

Not sure if it is intended to but if Initiate leaves the Golem, which he started to build, the Golem can finish building himself through regeneration.
« Last Edit: 1 December 2011, 11:51:00 by tomreyn »

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: [Bug] - Magic Faction, Golem can finish building himself
« Reply #1 on: 8 November 2011, 17:08:48 »
Which version are you referring to? Please DO read the sticky post which explains which info is required for a useful bug report.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

TotalNoob

  • Guest
Yes, very sorry for this one. Thread subject altered.

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
I just reproduced this bug. It's present since vanilla Glest. The problem is that the golem starts regenerating by the time the initiate starts building it. If the initiate cancels building the golem will continue to regenerate both HP and EP, and finally have full HP and EP. By this time it is still the small piece of stone and cannot move or attack. If, however, an initiate attacks the golem, then heals it, the Golem will become functional immediately when it reaches full health again.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

TotalNoob

  • Guest
Question is what the creators of Glest had in mind. Maybe they wanted it that way or did it unintentionally. Personally I think we can consider this bug as a feature :)

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
I'd prefer to correct it to let regeneration finish building or remove regeneration on on-build-mode.

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Question is what the creators of Glest had in mind. Maybe they wanted it that way or did it unintentionally. Personally I think we can consider this bug as a feature :)

If it was a feature then you would not need to attack the golem once it has full EP + HP. Currently that's neccessary since, if you don't, the golem will not mutate and you just have a block of stone there with lots of HP + EP, which can neither move nor attack / defend.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

TotalNoob

  • Guest
Oh now I get it. Then you are right.

Ishmaru

  • Behemoth
  • *******
  • Posts: 1,071
  • um wat??
    • View Profile
    • DelphaDesign
Should the fix be to have Golem complete himself when max hp, or to not regenerate hp while being built? Or both, tech/faction specific?
Annex: Conquer the World Release 4 For Pc Mac + Linux
https://forum.megaglest.org/index.php?topic=9570.0
Annex is now on Facebook!
https://www.facebook.com/AnnexConquer

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Thanks for bringing us back on track by asking the question of how to fix it, Ishmaru.

Having it configurable would allow for a nice tweak. By default, or if configurablity involves more work than is considered worth spending on this, I'd say units should never generate HP nor EP while being built, but only when they are complete and start to 'live'.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #10 on: 15 November 2011, 21:47:50 »
Having it configurable would allow for a nice tweak. By default, or if configurablity involves more work than is considered worth spending on this, I'd say units should never generate HP nor EP while being built, but only when they are complete and start to 'live'.
I'm really not so sure. While I agree that the golem should not be "building itself", I like how it starts with EP (otherwise you'd have to wait a fair while after building the golem to even move it). In fact, ideally, I'd say units should start with full EP, but that could have the potential to offtip balance in existing factions, so either leaving the EP alone (that is, just have the HP regen start once built, with the EP regen starting once building begins), though perhaps we could use a separate feature request for the whole concept of such a feature.
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

TotalNoob

  • Guest
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #11 on: 23 November 2011, 23:09:35 »
Egyptian Air Pyramid has the same issue as Golem and behaves in the same way as Tomreyn described.

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #12 on: 24 November 2011, 12:26:13 »
I think no regeneration while in "be build" state is the right way?
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #13 on: 24 November 2011, 12:36:21 »
I think ep should regenerate but hp should not

Ishmaru

  • Behemoth
  • *******
  • Posts: 1,071
  • um wat??
    • View Profile
    • DelphaDesign
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #14 on: 24 November 2011, 14:09:57 »
Well the way I see it is the unit structure is not yet complete, so it shouldn't be generating ep until its functional. But if everyone wants ep generation while building I'm fine with that.
Annex: Conquer the World Release 4 For Pc Mac + Linux
https://forum.megaglest.org/index.php?topic=9570.0
Annex is now on Facebook!
https://www.facebook.com/AnnexConquer

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #15 on: 25 November 2011, 00:28:21 »
I'm with Ishmaru there. I would mind units stating with a given non-zero EP value, though. And they should start with 100% HP.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: [Bug] - 3.5.3 beta1, Magic Faction, Golem can finish building himself
« Reply #16 on: 30 November 2011, 16:01:02 »
This should be fixed in beta2 (titi made the change)

Ishmaru

  • Behemoth
  • *******
  • Posts: 1,071
  • um wat??
    • View Profile
    • DelphaDesign
This should be fixed in beta2 (titi made the change)

What was the fix? Disabling regeneration during building?
Annex: Conquer the World Release 4 For Pc Mac + Linux
https://forum.megaglest.org/index.php?topic=9570.0
Annex is now on Facebook!
https://www.facebook.com/AnnexConquer

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Titi made this change and I believe it was to disable regen during build.

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
yes
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

 

anything