[not a bug] r2794 The night is not really dark

[titi]

Is it just me or are the nights much too bright in MG ?  At least in linux the night never gets really dark!
For a test I have set 0,0,0 as the moonlightcolor which should be VERY dark, but it was still very good playable.
I think last time i tried it in windows the nights were very dark!

Is there really such a big difference between linux/windows nights? Or is there something wrong with the lighting of the nights in general?

I already looked at the code, but I didn't saw anything suspicious. I also tried MG 3.4.0 which had the same bright nights.

[Coldfusionstorm]

Vanilla glest Nights were WAAAAAY to dark, and up to some point in Megaglest they were TOO dark, if we want to have real dark nights, we need to have light sources on buildings and/or roads, ect,ect.

[titi]

Thats not the point. If the night was too dark before it was a problem of the tileset. Now somehow the tilesets have less control on the night darkness.

[Ishmaru]

I see this on windows 7 64 as well.  Tested night light to have 0,0,0 and night is only slightly darker than day, use to be near black in Vanilla glest

[tomreyn]

Some chat backlog on this, with links to screenshots, so this part of the discussion doesn't get lost...

<softcoder> titi_linux, maybe see if this change is the problem? http://megaglest.svn.sourceforge.net/viewvc/megaglest/trunk/source/glest_game/graphics/renderer.cpp?r1=2103&r2=2127
<softcoder> is it a units light source or something else?
<softcoder> the problem you mentioned
<titi_linux> the normal night
<titi_linux> the moonlight
<titi_linux> its much too bright now
<softcoder> is that a tileset thing?
<titi_linux> its in the tileset yes
<titi_linux> but even if you set it to 0 it's not dark
<titi_linux> old glest often was much too dark
<titi_linux> now we don't really have any more night :/
<titi_linux> even with moonlight color 0,0,0
<softcoder> hmm, that does not remind me of anything
<softcoder> whatever the change it is not obvious
<titi_linux> and it was a long time ago
<titi_linux> I tested 3.4.0 and it has the same problems
<titi_linux> maybe it's also a graphics driver problem?
<titi_linux> I must try vanilla glest to see it
<titi_linux> at least all my nvidia cards don't show really black night anymore
<tomreyn> i think i used to have nights on some MG version but they were no longer present at some point. which i liked (since things were often too dark before), and thus probably didn't realise as a bug.
<titi_linux> I already tried some things ingame and set the lighting manually to 0 in the renderer
<titi_linux> but no big effect
<titi_linux> it gets darker yes
<titi_linux> but not really black ( or near black ) as expected
<softcoder> setupLighting()
<softcoder> must be something here
<softcoder> titi_linux, could it be related to unit particles?
<softcoder> in tilesets?
<titi_linux> how?
<titi_linux> its lighted even in regions without particles
<titi_linux> but maybe they are rendered in the wrong moment?
<titi_linux> and change the light settings somehow?
<softcoder> titi_linux,
<softcoder> comment out: sc->getObject()->initParticles();
<softcoder> in world.cpp
<softcoder> and tell me if the darkness is working
<titi_linux> ok
<softcoder> I 'think' maybe it affects the darkness of the tileset
<softcoder> i did a small test
<softcoder> no that doesn't affect it )
<softcoder> tested again
<titi_linux> i will switch off unit particles in the options
<titi_linux> maybe ....
<softcoder> ok
<softcoder> i compared glest release
<softcoder> darkness is the same
<softcoder> if anything mg is a little darker
<softcoder> this was glest 3.2.2
<softcoder> using forest tileset
<softcoder> is there another tileset to test titi_linux, which shows it better?
<softcoder> i changed: FastSpeedLoops=20 to speed up the test
<titi_linux> just put 0,0,0 as moonlight color
<titi_linux> me too
<titi_linux> fast night s
<titi_linux> I have set in tileset.cpp:
<titi_linux>   const XmlNode *moonLightColorNode= parametersNode->getChild("moon-light");
<titi_linux>   moonLightColor.x= moonLightColorNode->getAttribute("red")->getFloatValue()/50;
<titi_linux>   moonLightColor.y= moonLightColorNode->getAttribute("green")->getFloatValue()/50;
<titi_linux>   moonLightColor.z= moonLightColorNode->getAttribute("blue")->getFloatValue()/50;
<titi_linux> so every tileset should be dark
<titi_linux> line 311
<titi_linux> all values/50
<softcoder> ok confirmed
<softcoder> same
<softcoder> on 3.2.2 and mg
<softcoder> i set moonlight to 0
<titi_linux> then it must be the graphics drivers
<softcoder> only difference is that units properly light up in mg
<titi_linux> they must have changed somehow
<softcoder> i compared on two monitors
<titi_linux> I remember glest to be much too dark
<softcoder> 3.2.2 and mg svn
<softcoder> it was VERY dark for me
<softcoder> in mg
<titi_linux> it was too drak to play sometimes
<softcoder> i could not almost see anything
<titi_linux> yes?
<softcoder> but the castle was lit up
<softcoder> in mg only
<titi_linux> wow I take a screenshot to show you
<softcoder> me too
<softcoder> http://www.soft-haus.com/glest/temp/screen12.jpg and http://www.soft-haus.com/glest/temp/screen13.jpg
<titi_linux> http://www.titusgames.de/tmp/screen121.jpg
<titi_linux> this is the darkest night possible for me
<softcoder> looks same to me
<softcoder> as what i have
<titi_linux> yes
<softcoder> and is the same as 3.2.2
<titi_linux> hm, so I remember wrong?
<softcoder> i think so
<titi_linux> ok
<titi_linux> I will ask the others too on the forum
<softcoder> strange that your pyramid has no light
<softcoder> unless you turned it off
<titi_linux> yes I did
<titi_linux> to see it
<titi_linux> the darkness
<softcoder> ok
<titi_linux> hm ok
<softcoder> i will upload a 3.2.2 screenshot
<softcoder> http://www.soft-haus.com/glest/temp/screen0.tga
<softcoder> looks the same to me

[Omega]

After reading that, I really don't think this is a bug. And never noticed any difference in the night darkness myself.