Author Topic: [not a bug] r3167: Savegames are not written if previous write is in progress  (Read 720 times)

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
This is a minor issue, but I'll report it anyways... If you press the button to save a game multiple times in quick succession then, while the game reports to have created a savegame everytimes you pressed the button, only the first game is actually saved. This seems to be because creating savegame files is a sequential process and there is no queueing.

Possible fixes (I assume):
  • Fail (silently or, better, with a message) to create another savegame if creating a savegame is already in progress
  • Make game saving threaded
« Last Edit: 20 March 2012, 15:15:24 by tomreyn »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

Bloodwurm

  • Guest
The game is still running WHILE it's saving?

It's not for nothing that usually saving a game is a blocking process.

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Actually, looking into this again, it looks more the the savegames are written every time you press the key, but they can end up being written to the same file (same filename) if you saved multiple games per second. I guess this makes this a non-issue. And yes, saving the game does seem to be a blocking process, it's just so quick you hardly realize it.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Mainly the issue is that the filename is tied to the current second, so saving multiple times per second will over-write.