Author Topic: [(p) fixed] 3.6.0.3/3.7.1: Windows uninstaller places installer background image in C:\  (Read 1666 times)

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
The Windows installer seems to place the installer background image (the yellow/golden colored epic scene where two opposing armies confront each other) in C:\ for some reason. I'm not sure why it can write there anyways, but it seems to be able and do so. The fix would be not to place this file anywhere other than, if needed, a temporary directory.

I may be mistaken in that this file was placed there by an earlier version of the installer/game (so not 3.6.0.3), but then you'd be aware you already fixed this...

Edit by Omega: Changed title to uninstaller
« Last Edit: 7 January 2013, 02:04:40 by Omega »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

MightyMic

  • Technician
  • ****
  • Posts: 150
  • To mod, or not to mod...
    • View Profile
Re: 3.6.0.3: Windows installer image places installer image in C:\
« Reply #1 on: 29 March 2012, 01:08:50 »
I just checked and mine is there as well, and I've only use 3.6.0.3 and the previous version. So it's happened in the latest two versions at least.

Ishmaru

  • Behemoth
  • *******
  • Posts: 1,071
  • um wat??
    • View Profile
    • DelphaDesign
Re: 3.6.0.3: Windows installer image places installer image in C:\
« Reply #2 on: 29 March 2012, 04:17:36 »
I only installed up to 3.6.0.2 up to this moment and I have it as well.
Annex: Conquer the World Release 4 For Pc Mac + Linux
https://forum.megaglest.org/index.php?topic=9570.0
Annex is now on Facebook!
https://www.facebook.com/AnnexConquer

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: 3.6.0.3: Windows installer image places installer image in C:\
« Reply #3 on: 29 March 2012, 10:09:07 »
Looks like this is a result of the $PLUGINSDIR variable not getting initialized via InitPluginsDir. I haven't edited the NSIS file, yet, though, since vim's code coloring doesn't seem to know of this command, so I'm a little worried whether it's still how to do this. The $TEMP variable could be an alternative option, should this not work out.

The advanced example called NSIS Beyond a Traditional Installation suggests to place both InitPluginsDir and File instructions in an .onInit function (which apparently serves as a hook).
« Last Edit: 29 March 2012, 10:18:31 by tomreyn »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Changed committed in svn, hopefully it will fix this.

MightyMic

  • Technician
  • ****
  • Posts: 150
  • To mod, or not to mod...
    • View Profile
This isn't fixed... At least not in version 3.7.0
Windows 7 SP1 - 64 bit

And the picture wasn't there before the install of MG 3.7.0

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Thanks for the updated report. MightyMic.

I just checked and mine is there as well, and I've only use 3.6.0.3 and the previous version. So it's happened in the latest two versions at least.

And the picture wasn't there before the install of MG 3.7.0

Hmm, to me, this seems somewhat contradictionary on first sighting. Are you saying the 3.6.0.3 installed placed this image in C:\ or not?
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

MightyMic

  • Technician
  • ****
  • Posts: 150
  • To mod, or not to mod...
    • View Profile
Re: 3.6.0.3: Windows installer places installer background image in C:\
« Reply #7 on: 29 November 2012, 00:46:52 »
Hmm, to me, this seems somewhat contradictionary on first sighting. Are you saying the 3.6.0.3 installed placed this image in C:\ or not?

Sorry, I guess I should have started a new topic...

I was trying to say that installer 3.7.0 Still places the image in C:\  drive

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: 3.6.0.3: Windows installer places installer background image in C:\
« Reply #8 on: 29 November 2012, 10:38:34 »
Confirmed for the 3.7.1 installer: the installer image is placed in the C drive. It was not there before, nor was I even installing to the C drive.

Also related to the installer, can we please convert those dialogue boxes into checkboxes (defaulting to off)? Just feels a bit pressuring to have three prompts when I think I'm done, and hitting enter will cause something else to open up.
« Last Edit: 29 November 2012, 11:18:36 by Omega »
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
I was doing some testing based on a comment by MightyMic. It's not the installer, it's the uninstaller that's adding this image.

The reason I thought it was the installer is because installing a new version will try and uninstall the older version first.
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert