[not a bug] r3235: FileArchiveExtractCommandParameters to be quoted on Linux?

[tomreyn]

There's a little difference in the value of the FileArchiveExtractCommandParameters option in glest.ini for Windows vs Linux:

Code: [Select]

tomreyn@atibox:~$ grep '^FileArchiveExtractCommandParameters' SCM/megaglest-trunk/data/glest_game/glest.ini SCM/megaglest-trunk/mk/linux/glest.ini
SCM/megaglest-trunk/data/glest_game/glest.ini:FileArchiveExtractCommandParameters=x -o"{outputpath}" "{archivename}"
SCM/megaglest-trunk/mk/linux/glest.ini:FileArchiveExtractCommandParameters=x -o{outputpath} {archivename}
tomreyn@atibox:~$

I assume these values should be equal, using the quoted notation on both Windows and Linux?

[softcoder]

Why do you assume this? Are you experiencing a problem?

[tomreyn]

I'm not, I'm really just assuming it may be necessary since there can be blank spaces in file or directory names on Linux, too. It's just that I became aware of this difference between the Windows and Linux glest.ini files and it seemed like this was an improvement made on the Windows one, which was forgotten to be copied to the Linux one.

[softcoder]

It highlights the OS specific API differences between Windows and Linux, and should only be required for Windows due to how the API works on that OS.