[fixed] 3.6.0.3: Text chat messages may be attributed to wrong player

[tomreyn]

Titi was hosting a game where he already had some players connected. Titi said "no downloads", then changed into another slot (which may or may not have been a network slot before he moved there). Very shortly after Titi switched slots, I connected to his server, ended up in Titi's old slot and said "yeay". What happened then is that what Titi said before, namely "no downloads" was reattributed to me, as if I had said it (but I had not, and I could not, since I was not fully connected when Titi wrote this).

I'm not sure whether this issue is still present in current development stage code, but I assume it is.

[softcoder]

Do we have steps to reproduce this on svn head?

[tomreyn]

Not, yet. It does affect svn head (or almost head, it did occur on a rather recent revision), too, though. So we need more testing here to create precise steps to reproduce it. I'll tag it as [testing].

[tomreyn]

Pizza, Jammy and I tried to reproduce this but were unable to. And while we ran into a related issue (Console chat may replace player name by question marks) I assume this one is no longer reproduclible on svn head.