Author Topic: [fixed] r3412: MG crashes when there are no scenarios or tutorials  (Read 779 times)

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
I gave the Republic vs Police State game a try yesterday (much fun! :) ). It doesn't come with any tutorials or scenarios. As such, when you enter these menus MegaGlest needs to handle this situation. Currently it doesn't seem to be able to cope with this. A workaround would be to hide these menus, but actually handling this situation would be nicer so that full conversions have more freedom there. I'm not providing log files at this time (please say so if they are still needed) since this should be fully reproducible.
« Last Edit: 5 July 2012, 00:22:23 by tomreyn »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: r3412: MG crashes when there are no scenarios or tutorials
« Reply #1 on: 30 June 2012, 19:17:53 »
Fixed in svn

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: r3412: MG crashes when there are no scenarios or tutorials
« Reply #2 on: 1 July 2012, 10:51:04 »
I appreciate that you added a warning which displays after the user has entered the scenario or tutorial menu, saying that none are available.
However, after closing this message, the user still has the option to start the game by hitting the "Play now" button (with a NULL value for the scenario/tutorial), and if she does, the game still crashes. Maybe you could remove or better disable the button to start the game in this case? Or, even better, bump the user back to the menu she came from instantly after closing the message box?

The code could possibly be copied from the "Load Saved Game" menu where the "Load Saved Game" button has no function if no savegave was selected (and none is selectable if none is available).
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: r3412: MG crashes when there are no scenarios or tutorials
« Reply #3 on: 3 July 2012, 00:26:55 »
Fixed in svn, it will return to the previous menu on click.

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Confirmed fixed, thank you!
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

 

anything