[not a bug] Attack boost bug - SVN 3545

[Coldfusionstorm]

Allright

Basically under some circumstances the attack boost's can mess up,and mess around in it's internal parameters.

This is the files showing the bug in action.
http://www.mediafire.com/?6sqt024a80g247l

First there is two "generals" Named General and General 2.

These have 3 attackboot's in total all centred about the stop skill.

general have two attack boost's.

A drain enemy life one and a boost friendly units.

General 2 have a simple attack boost and to be honest i think identical to General's positive attack boost.

I was trying to replicate a bug i had in my own game(G.i.S), So that's why there is two different generals but the bug appared before i adjusted the second unit.

allright, To the image explanation

General_drain_ability.jpg
friendly_boost.jpg

These images show the stat's of the general. As you can see the radius is massive (in my own game hower the range was only 6.).

As you can see the general have a ability that removes enemy health. And this is the one that he is currently using.

And the second ability grans damage and _sight_. Note the sight, that is important.

Now first we look at the image called close_catapult_normal.jpg this picture dipicts a catapult far inside the range and thus losing life to the generals drain life ability.

Now we take a look at the image called:
catapult_far_away_wait_what_minus_range.jpg

Now what is this?. This is a catapult that is farther away but still inside the range, but it does not recive damage?, and whatmore it have a _minus_ range modifier of 90.

And if we look farther away we also see a spearman that also isnt affected by the damage attackboost

in this image:
spearman_not_affected.jpg

And a better picture
better_look_at_spearman_not_affected.jpg

Windows 7 64 Bit. - Service pack 1.

Cpu AMD Bulldozer 4100
8 Gigs ddr3 Ram
Nvidia geforce 8800
And different perhiphals.

[softcoder]

This is not a bug, you should avoid having multiple stop skills because stop skill is what is auto set after every command is completed, having multiple may cause undefined problems.

[Coldfusionstorm]

Perhaps a line defining wich skill is the default?, this could also be usefull for different move skills, and attack skills.

[Omega]

This is not a bug, you should avoid having multiple stop skills because stop skill is what is auto set after every command is completed, having multiple may cause undefined problems.

Really? I was under the presumption that the first instance of the skill would be used? If this is the cause of the issue, perhaps, as CFS suggested, we should have a way to specify which one is the default for when there is no other commands in their queue (I propose simply using the first stop skill in the XML, rather than adding an unnecessary extra element). I used multiple stop skills in a number of units in Apocalyptic Dawn, where there was a regular stop skill and a hold position stop skill (which used a different model so units would appear to be fortified). It worked perfectly, and I assumed it was because the "regular" stop skill came first in the XML (although I suppose it could potentially be because the stop command used that skill as well; never tested further). Yeah, it was a different engine, and no attack boost, although it does highlight the need for a "default stop skill".

[tomreyn]

Please also keep in mind that these are the MegaGlest forums, thank you. Suggestions for improvements on MegaGlest, especially in the form of patches, are welcome here.

[Omega]

Please also keep in mind that these are the MegaGlest forums, thank you. Suggestions for improvements on MegaGlest, especially in the form of patches, are welcome here.

Really? I was under the presumption that the first instance of the skill would be used? If this is the cause of the issue, perhaps, as CFS suggested, we should have a way to specify which one is the default for when there is no other commands in their queue (I propose simply using the first stop skill in the XML, rather than adding an unnecessary extra element).

[Coldfusionstorm]

I think omegas suggestion makes good sense, currently commands are also sorted after wich order they are in the xml.

[Ishmaru]

What about using hold position for boosts?

(click to show/hide)

Code: [Select]

<?xml version="1.0" standalone="no"?>

<unit>

<!-- *** parameters *** -->

<parameters>
<size value="2"/>
<height value="3"/>
<max-hp value="400" regeneration="0"/>
<max-ep value="50" regeneration="1"/>
<max-unit-count value="1"/>
<armor value="0"/>
<armor-type value="heavy"/>
<sight value="10"/>
<time value="50"/>
<multi-selection value="true"/>
<cellmap value="false"/>
<levels>
</levels>
<fields>
<field value="land"/>
</fields>
<properties>
<property value="rotated_climb"/>
</properties>
<light enabled="false"/>
<unit-requirements>
<unit name="shadow_lab"/>
</unit-requirements>
<upgrade-requirements>
<upgrade name="energy_barrier"/>
</upgrade-requirements>
<resource-requirements>
<resource name="credit" amount="60"/>
<resource name="supplies" amount="20"/>
<resource name="unit" amount="5"/>
</resource-requirements>
<resources-stored/>
<image path="../../../../../base_battle/icons/icons/shield.bmp"/>
<image-cancel path="../../../../../base_battle/icons/icons/scancel.bmp"/>
<meeting-point value="false"/>
<selection-sounds enabled="true">
<sound path="../../../../../base_battle/voice/ma2_sel1.wav"/>
<sound path="../../../../../base_battle/voice/ma2_sel2.wav"/>
</selection-sounds>
<command-sounds enabled="true">
<sound path="../../../../../base_battle/voice/ma2_ack1.wav"/>
<sound path="../../../../../base_battle/voice/ma2_ack2.wav"/>
<sound path="../../../../../base_battle/voice/ma2_ack3.wav"/>
</command-sounds>
</parameters>

<!-- *** skills *** -->

<skills>

<skill>
<type value="stop"/>
<name value="stop_skill"/>
<ep-cost value="0"/>
<speed value="500"/>
<anim-speed value="5"/>
<animation path="../../../../../base_battle/models/unit/generatorstand.g3d"/>
<sound enabled="false"/>
</skill>

<skill>
<type value="stop"/>
<name value="shield_skill"/>
<ep-cost value="50"/>
<speed value="14"/>
<anim-speed value="5"/>
<animation path="../../../../../base_battle/models/unit/generatorshield.g3d"/>      <particles value="true">
         <particle-file path="../../../../particles/shield_glow.xml"/> <particle-file path="../../../../particles/shield_ground.xml"/>
</particles>
<attack-boost>
<allow-multiple-boosts value="false" />
<radius value="8"/>
                        <target value="ally" include-self="true">
</target>
<max-hp value="0"/>
<max-ep value="0"/>
<sight value="0"/>
<attack-strenght value="0"/>
<attack-range value="0"/>
<armor value="1000"/>
<move-speed value="0"/>
<production-speed value="0"/>
<particles value="true">
<!--originator-particle-file path="../../../../particles/guard.xml"/-->
<affected-particle-file path="../../../../particles/guard.xml"/>
</particles>
                        </attack-boost>
<sound enabled="true" start-time="0.0">
<sound-file path="../../../../../base_battle/sound/shield.wav"/>

</sound>
</skill>


<skill>
<type value="move"/>
<name value="move_skill"/>
<ep-cost value="0"/>
<speed value="400"/>
<anim-speed value="70"/>
<animation path="../../../../../base_battle/models/unit/generatorrun.g3d"/>       <particles value="true">
         <particle-file path="../../../../particles/dust.xml"/>
</particles>
<sound enabled="false"/>
</skill>

<skill>
<type value="attack"/>
<name value="attack_skill"/>
<ep-cost value="0"/>
<speed value="300"/>
<anim-speed value="170"/>
<animation path="../../../../../base_battle/models/unit/generatorstand.g3d"/>
<particles value="true" start-time="0.1" end-time="1">
</particles>
<sound enabled="true" start-time="0.10">

</sound>
<attack-strenght value="0"/>
<attack-var value="0"/>
<attack-range value="0"/>
<attack-type value="spy"/>
<attack-start-time value="0.9"/>
<attack-fields>
<field value="land"/>
</attack-fields>
<projectile value="false"/>
<splash value="true">
<radius value="1"/>
<damage-all value="true"/>
<particle value="false"/>

</splash>
</skill>

<skill>
<type value="die"/>
<name value="die_skill"/>
<ep-cost value="0"/>
<speed value="60"/>
<anim-speed value="100"/>
<animation path="../../../../../base_battle/models/unit/relaydie.g3d"/>    <particles value="true">
         <particle-file path="../../../../particles/damage_smoke.xml"/>
</particles>
<sound enabled="true" start-time="0">
<sound-file path="../../../../../base_battle/sound/tank_destroy_2.wav"/>
</sound>
<fade value="false"/>
</skill>

</skills>

<!-- *** commands *** -->

<commands>

<command>
<type value= "stop"/>
<name value="stop"/>
<image path="../../../../../base_battle/icons/icons/sstop.bmp"/>
<unit-requirements/>
<upgrade-requirements/>
<stop-skill value="stop_skill"/>
</command>

<command>
<type value="move"/>
<name value="move"/>
<image path="../../../../../base_battle/icons/icons/smove.bmp"/>
<unit-requirements/>
<upgrade-requirements/>
<move-skill value="move_skill"/>
</command>

<command>
<type value="attack_stopped"/>
<name value="shield_activate"/>
<image path="../../../../../base_battle/icons/icons/shieldon.bmp"/>
<unit-requirements/>
<upgrade-requirements/>
<stop-skill value="shield_skill"/>
<attack-skill value="attack_skill"/>
</command>

<command>
<type value="attack_stopped"/>
<name value="shield_disabled"/>
<image path="../../../../../base_battle/icons/icons/noshield.bmp"/>
<unit-requirements/>
<upgrade-requirements/>
<stop-skill value="stop_skill"/>
<attack-skill value="attack_skill"/>
</command>
</commands>
</unit>

Trick is to use the boost stop skills in hold position commands.

In case you have no idea whats happening here this unit

stop skill (default skill which allows unit to auto shield when an enemy approaches)
move skill (self explanatory)
attack skill (used as the auto shield ability)
hold position 1 (used as a manual shield ability)
Hold position 2 (used as a stop/no shield ability)