Author Topic: [fixed] Localization keys should not contain blank spaces  (Read 656 times)

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
There are a couple localization keys (the identifiers/vriables left of the equals character in the language files) which contain blank spaces. I think that's not good style and we should replace them by ones which use CamelCase (like most do now) or use underscores.
Code: [Select]
tomreyn@atibox:~/SCM/megaglest-trunk$ grep -E '^[^;][^=]* ' data/glest_game/data/lang/english.lng
Connection failed=Connection failed
Couldnt connect=Connection failed. Choose another Server.
To switch off music press=To switch off music while waiting for players press
tomreyn@atibox:~/SCM/megaglest-trunk$
Plus there is at least one more which is not listed in english.lng:
Code: [Select]
left at (min)
This came up while some Pootle developers/contributors tried to convert these files to .po format for testing on pootle.
« Last Edit: 18 October 2012, 15:09:59 by softcoder »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

Zhook

  • Guest
Re: Localization keys should not contain blank spaces
« Reply #1 on: 22 July 2012, 01:51:38 »
What camelcase is?

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: Localization keys should not contain blank spaces
« Reply #2 on: 22 July 2012, 02:24:15 »
What camelcase is?
CamelCase. It'sWhenYouCapitalizeTheFirstLetterInTheWordInsteadOfUsingSpaces.
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

 

anything