[fixed] setUnitPosition crash

[treba]

hey

i found some more bugs concerning setUnitPosition.
i'm trying to use it as a escape skill for a hero.
the hero summons a dummy size-zero unit to trigger an unitCreatedOfType event.
the content of that reads as follows:

Code: [Select]

if unitFaction(lastCreatedUnit()) == 0 then
   setUnitPosition(variable_hero_1,{(startLocation(unitFaction(lastCreatedUnit()))[1] + 3), (startLocation(unitFaction(lastCreatedUnit()))[2] + 3)})
end
destroyUnit(lastCreatedUnit())
so nothing special so far.

now the wierd stuff starts:

• the units which surrounded my hero before he escaped using the summon skill stay visible, although being in the fog of war
• they all turned around in the new direction of my hero, attacking the air in front of them
• after some time like 10-30 second, i'm not sure yet what has to happen, the game crashes

Code: [Select]

[2012-10-11 13:36:51] *ERROR* In [game.cpp::update Line: 1762] Error [trying to move into occupied cell and field]

EDIT: actually, the error given above happens because the teleported unit gets killed by the units hitting the air.
they don't do any damage after the teleport as long as the teleported unit doesn't get any new commands. as soon as it gets one (also when it spots an enemy for example), it's recieving damage again.

[softcoder]

Try svn again, i added more details for that error.

[treba]

Code: [Select]

*ERROR* In [game.cpp::update Line: 1764] Error [Trying to move unit [300005 - swordman] into occupied cell [x [97] y [23]] and field = 0, unit already in cell [9 - archmage_level_1] ]

well that's wierd, the archmage is dead by that time. and was far away before.

[softcoder]

Try calling:

isUnitAlive for the archmage and check. He must not be dead if you are getting this error.

[treba]

well, as explained above, he's losing hp and dies, with death animation. i watched that a couple of times now.

should i upload the scenario so you can test it yourself?

[softcoder]

Sure

[treba]

http://dl.dropbox.com/u/56789020/Swordman_Frenzy.7z

steps to reproduce:

• build an archmage in the tower
• move it into one of the enemy bases to get attacked
• click on the teleport button (has a tower on it)
• when the archmage is back, give it one more commands

[softcoder]

This was a bug in setUnitPosition(). Svn has it fixed now, thanks

[titi_son]

Mark as fixed?