Author Topic: [fixed] 3.7.0 Winning Team is displayed wrong  (Read 2679 times)

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
[fixed] 3.7.0 Winning Team is displayed wrong
« on: 13 November 2012, 14:49:53 »
The winning Team is displayed wrong after player died, before the end of the game and his team mates won that game.

Version 3.7.0
System: Windows 7

Reproduce: start a game with 3 players in 2 teams.
the player that plays alone eliminate one of the others and gets killed afterwards.
Now the player who died first will be shown that his team has lost ... even if it actually won
« Last Edit: 15 January 2013, 05:38:52 by softcoder »

Manric

  • Guest
Re: 3.7.0 Winning Team is displayed wrong
« Reply #1 on: 13 November 2012, 18:07:30 »
I have been trying to get this error, and no, it does not happen. But a similar effect to what you describe may arise with this setup:
Three players, one Human, with a CPU ally, and another player. 
Now, if the human-run faction is destroyed, the game is considered over, with the human a loser, even if the CPU ally is still active. If the endgame prompt is not accepted, whatever happens from now does not count. So, if the ally gets a win over the other faction and you then end the game expecting to see a victory, it will not be there. The game was lost before.

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: 3.7.0 Winning Team is displayed wrong
« Reply #2 on: 13 November 2012, 18:13:12 »
Yes, that's the same error

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: 3.7.0 Winning Team is displayed wrong
« Reply #3 on: 15 November 2012, 09:18:47 »
I think there is nothing wrong. If you are dead before end of game you are dead and by this you lost. It doesn't matter which team you belong to. For me thats not a bug.
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: 3.7.0 Winning Team is displayed wrong
« Reply #4 on: 15 November 2012, 12:19:59 »
But if you watch the rest of the game and your teammates win, then for you they are even shown as looser and the defeated enimies as winner, which can not be corrrect.

I think there is nothing wrong. If you are dead before end of game you are dead and by this you lost. It doesn't matter which team you belong to.
But isn't that the reason to play in teams, that the team as team wins or looses ...

+ in real life it is always handled as I described: In WW2 France was defeated by Germany. But after Germany lost, France was a winner of WW2, because it's "teammates" won.
« Last Edit: 15 November 2012, 12:55:08 by MuwuM »

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: 3.7.0 Winning Team is displayed wrong
« Reply #5 on: 15 November 2012, 13:56:08 »
If you are dead it doesn't matter if your team wins or not. You lost everything, no matter what your team does. At last you are for sure NOT a winner. The team might be a winner, but you are not in this case.

To stay with your example: If every french person and city would have been killed/destroyed noone would call them a winner, because noone would be left to win.
« Last Edit: 15 November 2012, 14:25:54 by titi »
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: 3.7.0 Winning Team is displayed wrong
« Reply #6 on: 15 November 2012, 14:41:04 »
Teams normally have members with complementary skills and generate synergy through a coordinated effort which allows each member to maximize his/her strengths and minimize his/her weaknesses. Team members need to learn how to help one another, help other team members realize their true potential, and create an environment that allows everyone to go beyond their limitations

Having this quotation in mind:
A weaker player plays with a very good one. The good player will need a lot of this power to help the weaker one. And if can't rescue the weak player form a heavy attack that player will be defeated. But as a good player he manages it to kill the enimies afterwards. And now te weak player sees the end-of-game-screen and for him his whole team is shown as looser, and his defeatet enimies are shown as winner.
That can not  be the correct way to threat teams.

You can say, each Player wins or looses seperated from all other players. But then I will not support my team, if my own defence is not strong enougth.
OR
The win is set per team and then the whole team can behave as team without beiing afraid of dieing.


To stay with your example: If every french person and city would have been killed/destroyed noone would call them a winner, because noone would be left to win.
But you as player are not killed, its just the units you control ... if in war a general looses his whole army, but stay alive. And the contry wins, he is still part of the winner.

Manric

  • Guest
Re: 3.7.0 Winning Team is displayed wrong
« Reply #7 on: 15 November 2012, 16:29:07 »
Sorry, MuWum, but you are not right in your arguments. You see, the crucial point here is that we have a human player with one or more CPU allies. The logic of the game dictates that it is the human-run faction the only one that matters. If it is wiped out there is no point in continuing the game: what for? You obviously started this game to enjoy yourself playing, not to watch the AI doing its job. If you want to do that, just set up a new game as observer and enjoy the show. (Incidentally, I often do it, using custom maps and all kinds of factions, and it is a lot of fun).

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: 3.7.0 Winning Team is displayed wrong
« Reply #8 on: 15 November 2012, 17:53:31 »
I have to admit, MuwuM's logic seems sound to me. The human player is indeed the "centerpiece" of the game, and AI wins don't really matter much, but at the same time, if an AI ally wins, the human, by the rules of the game, wins too. If the ally was an AI, then they would have won if our roles were reversed, so there's no reason for the double standard. The only thing is: it doesn't really matter much. There's not much reason to watch a game after you have died, even if you do have allies. After all, winning in these cases is all about fun, and it's not very fun to sit back and hope your computer controlled ally triumphs. So while the human player is the only one that matters to the player, and there is indeed no point in continuing the game, they still technically won if their ally wins. It's a really, really minor issue, though.
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: 3.7.0 Winning Team is displayed wrong
« Reply #9 on: 15 November 2012, 18:10:41 »
I'm not talking about playing with CPU in your team, I'm telling to play with human(s) agains CPU and/or other humans.... and when I have played three games in a row with a person, I will watch the end of game even if I was defeated.

MoLAoS

  • Ornithopter
  • *****
  • Posts: 433
    • View Profile
Re: 3.7.0 Winning Team is displayed wrong
« Reply #10 on: 15 November 2012, 19:17:35 »
Muwum is technically correct. If you are playing a team game vs another team, as opposed to a game where you ally with someone but are not actually on their team, you should be winning the game as a team.

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: 3.7.0 Winning Team is displayed wrong
« Reply #11 on: 15 November 2012, 19:45:28 »
I'm not talking about playing with CPU in your team, I'm telling to play with human(s) agains CPU and/or other humans.... and when I have played three games in a row with a person, I will watch the end of game even if I was defeated.
Oh. Well, still applies.
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: 3.7.0 Winning Team is displayed wrong
« Reply #12 on: 15 November 2012, 20:38:39 »
Only problem is the result is in no way team related! Its your personal result and shown as this in the endgame stats too.
You might want to interpret it as a team result, but its not.
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: 3.7.0 Winning Team is displayed wrong
« Reply #13 on: 15 November 2012, 20:48:01 »
Only problem is the result is in no way team related! Its your personal result and shown as this in the endgame stats too.
You might want to interpret it as a team result, but its not.

Then why is my team mate shown as looser, when he defeated all the enimies?

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: 3.7.0 Winning Team is displayed wrong
« Reply #14 on: 15 November 2012, 21:40:58 »
now I see the problem:
this is MuwuMs screenshot, he lost , but his teammate (carla) later won while he was watching the game. In the end in Muwums endgame stats the team that lost was marked as winners! So I did not get what the problem was.

(update: But the behaviour was like this in all MG versions and in original glest too.)

« Last Edit: 18 November 2012, 22:51:44 by titi »
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: 3.7.0 Winning Team is displayed wrong
« Reply #15 on: 20 November 2012, 02:27:56 »
Fixed in svn rev#:3932

If your team wins (and you hang around in game until they officially win) than the battle end screens shows your team as winners.

titi

  • MegaGlest Team
  • Airship
  • ********
  • Posts: 4,240
    • View Profile
    • http://www.titusgames.de
Re: 3.7.0 Winning Team is displayed wrong
« Reply #16 on: 20 November 2012, 10:40:38 »
Are you also shown as a winner in this case too even if you died in the game? Thats indeed better than before!
But still ( maybe only for me ) the fact that you are shown as a winner is still wrong, as there is not diplayed a team result but a result for each player.
Regarding MuwuMs requirements for his Mod , I can life with the endgame results as they are now.
Try Megaglest! Improved Engine / New factions / New tilesets / New maps / New scenarios

Omega

  • MegaGlest Team
  • Dragon
  • ********
  • Posts: 6,167
  • Professional bug writer
    • View Profile
    • Personal site
Re: 3.7.0 Winning Team is displayed wrong
« Reply #17 on: 20 November 2012, 19:51:24 »
But still ( maybe only for me ) the fact that you are shown as a winner is still wrong, as there is not diplayed a team result but a result for each player
Well, if I play with an ally and my ally dies, yet I go on to win, my ally is still considered a winner, so this just appears to be elimination of that double standard. Still, why are we making such a big deal about the displayed winner in an AI match?
Edit the MegaGlest wiki: http://docs.megaglest.org/

My personal projects: http://github.com/KatrinaHoffert

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: 3.7.0 Winning Team is displayed wrong
« Reply #18 on: 22 November 2012, 20:44:08 »
Are we ok with how this displays now (those who tested svn)?