[not a bug] Problematic implementation methods of Battle End Video/Music

[Ishmaru]

Trying to set up battle end video/music I found that many of the methods outlined in this feature: https://forum.megaglest.org/index.php?topic=8618.0  do not work.

For example:

Videos:
look for videos in the following order:
1. check faction xml file for the following attributes (depends on win/lose) on the faction tag:
faction-battle-end-win-video="<path to video>"
faction-battle-end-lose-video="<path to video>"
3.if not found check the data/core/menu/videos/ paths for:
battle_end_win.*
battle_end_lose.*

Music:
 added support for custom music on battle end screen:
look for music in the following order:
1. check faction xml file for the following attributes (depends on win/lose) on the faction tag:
faction-battle-end-win-music="<path to music>"
faction-battle-end-lose-music="<path to music>"
3.if not found check the data/core/menu/music/ paths for:
battle_end_win.*
battle_end_lose.*

Nor does this method, Which was intended to fix issues mentioned above.

<?xml version="1.0" standalone="no"?>
<faction battle-end-win-video="x_battle_end_win_video.avi" battle-end-lose-video="x__battle_end_lose_video.avi" >
etc..

The only method that works is:

Videos:

2. check the faction folder for the files:
battle_end_win_video.*
battle_end_lose_video.*

Music:

2. check the faction folder for the files:
battle_end_win_music.*
battle_end_lose_music.*

Following other methods will not result in a crash, just ignored. Normally this would not be an issue, but if a mod is several techtrees big its quite wasteful. In Annex case I would have the same 4 videos and musics cloned in almost 20 techtrees. A huge and completely unnecessary increase in data size.

[softcoder]

Please post your specific test cases that fail with example of xml used for each one.

Thanks

*Update:

The xml tags should not have the word faction in them when used in a faction xml file, example:

Code: [Select]

battle-end-win-video
battle-end-lose-video

[tomreyn]

I see both hyphons and underscores here, which one is correct?

[softcoder]

hyphen for xml tag names, underscores for filenames.

[tomreyn]

Oh, right, now you're explaining it I realise this wasn't an issue in the first place.

[Ishmaru]

Please post your specific test cases that fail with example of xml used for each one.

Thanks

*Update:

The xml tags should not have the word faction in them when used in a faction xml file, example:

Code: [Select]

battle-end-win-video
battle-end-lose-video

What is the exact syntax if i wanted to specify both a video and audio in a specific location lets say "techs/base_battle/video" from a faction xml? And where does it go in the xml

I tried to use <battle-end-win-video="../../../base_battle/video/alliance_battle_end_win_video.wmv" battle-end-lose-video="../../../base_battle/video/alliance_battle_end_win_video.wmv">  which does not work..

[softcoder]

if you run with

Code: [Select]

--verbose then the console will show exact paths used for files.

Thanks

[tomreyn]

I'm not sure I understood the outcome properly, but reading over this thread my impression is this is not a bug - am I wrong?