[done] Shortcut key for attacking should cycle through attack skills

[ctz]

Pressing the shortcut key for attacking (default is 'A') selects/deselects the primary attack for the selected units.  There is no keyboard shortcut I know of that allows for selecting the secondary attack, which is selected by clicking its icon or automatically activated by attacking (right-clicking) a unit that can be attacked by secondary but not by primary.

I propose cycling through the attack skills, so e.g. if Tech's Battle Machine is the selected unit, pressing 'A' would select, in order, Attack->Attack Arrow->no action.

If multiple units of the same type are selected, cycling should work as if only one unit is selected.  If units of different types are selected, only the primary attack should be selected.

[titi]

Yeah this is something I also thought about and I will add it. But how is the behaviour if the selection is a mixed group of fighters ?

Options we have:
if its a mixed group we ...
- ... don't cycle through the attack skills ( I prefer this )
- ... we use the first one in selection to switch the skills and all other units switch too if they have a 2nd or 3rd attack skill of same field too. If they don't have one, they stay with first attack skill ( to complicated in my opinion )
- ... we automatically change the selection to those having the same unit type as the first selected unit and switch. ( well, somthing to think about, but does too much in my opinion)

[MightyMic]

- ... don't cycle through the attack skills ( I prefer this )

I too prefer this

[titi]

done in svn, please test and give feedback.