[fixed] Client freezes when server quits; was: (r4168) Crash when leaving game

[titi]

Every 50% I get a crash when I leave a multiplayer game: http://pastebin.com/raw.php?i=9WVgSj9W

We just start the game and after playing some seconds I try to leave the game ( as client ) 0> crash

[softcoder]

Does this still occur on svn head?

[titi]

yes, but not sure its the same:

With the change I made in svn I get a freeze ( I asume endless waiting ). Without the change  I get a crash.

Code: [Select]

#0  0x00007fc430708425 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#0  0x00007fc430708425 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fc43070bb8b in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fc43074639e in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fc4307dc807 in __fortify_fail () from /lib/x86_64-linux-gnu/libc.so.6
#4  0x00007fc4307db700 in __chk_fail () from /lib/x86_64-linux-gnu/libc.so.6
#5  0x00007fc4307dc7be in __fdelt_warn () from /lib/x86_64-linux-gnu/libc.so.6
#6  0x0000000000aaa36d in Shared::Platform::Socket::isWritable (this=0x379b7f0, timeVal=<optimized out>) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1715
#7  0x0000000000aacfc7 in Shared::Platform::Socket::isConnected (this=0x379b7f0) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1760
#8  0x0000000000aae6e9 in Shared::Platform::Socket::getDataToRead (this=0x379b7f0, wantImmediateReply=false) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1157
#9  0x0000000000865c9a in Glest::Game::NetworkInterface::getNextMessageType (this=0x3e94230) at /home/tscharn/glest/megaglest/source/glest_game/network/network_interface.cpp:86
#10 0x000000000087c0dd in Glest::Game::ClientInterface::waitForMessage (this=0x3e94230) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:1664
#11 0x0000000000883c9e in Glest::Game::ClientInterface::updateFrame (this=0x3e94230, checkFrame=0x0) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:866
#12 0x00000000008872f0 in updateNetworkFrame (this=<optimized out>) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:847
#13 Glest::Game::ClientInterfaceThread::execute (this=0x6317940) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:115
#14 0x0000000000a6eaff in Shared::Platform::Thread::beginExecution (data=<optimized out>) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/sdl/thread.cpp:85
#15 0x00007fc43428afd5 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#16 0x00007fc4342ce999 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#17 0x00007fc434062e9a in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#18 0x00007fc4307c5cbd in clone () from /lib/x86_64-linux-gnu/libc.so.6
#19 0x0000000000000000 in ?? ()


[titi]

no sure from when the above one was but its still present in rev 4181:

Code: [Select]

#0  0x00007f3778f5a425 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#0  0x00007f3778f5a425 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f3778f5db8b in abort () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007f3778f9839e in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007f377902e807 in __fortify_fail () from /lib/x86_64-linux-gnu/libc.so.6
#4  0x00007f377902d700 in __chk_fail () from /lib/x86_64-linux-gnu/libc.so.6
#5  0x00007f377902e7be in __fdelt_warn () from /lib/x86_64-linux-gnu/libc.so.6
#6  0x0000000000aaa88d in Shared::Platform::Socket::isWritable (this=0x3443940, timeVal=<optimized out>) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1715
#7  0x0000000000aad4e7 in Shared::Platform::Socket::isConnected (this=0x3443940) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1760
#8  0x0000000000aaec09 in Shared::Platform::Socket::getDataToRead (this=0x3443940, wantImmediateReply=false) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/posix/socket.cpp:1157
#9  0x000000000086615a in Glest::Game::NetworkInterface::getNextMessageType (this=0x2dee630) at /home/tscharn/glest/megaglest/source/glest_game/network/network_interface.cpp:86
#10 0x000000000087c5cd in Glest::Game::ClientInterface::waitForMessage (this=0x2dee630) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:1670
#11 0x000000000088418e in Glest::Game::ClientInterface::updateFrame (this=0x2dee630, checkFrame=0x0) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:872
#12 0x00000000008877a3 in updateNetworkFrame (this=<optimized out>) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:853
#13 Glest::Game::ClientInterfaceThread::execute (this=0x3d57a90) at /home/tscharn/glest/megaglest/source/glest_game/network/client_interface.cpp:115
#14 0x0000000000a6f01f in Shared::Platform::Thread::beginExecution (data=<optimized out>) at /home/tscharn/glest/megaglest/source/shared_lib/sources/platform/sdl/thread.cpp:85
#15 0x00007f377cadcfd5 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#16 0x00007f377cb20999 in ?? () from /usr/lib/x86_64-linux-gnu/libSDL-1.2.so.0
#17 0x00007f377c8b4e9a in start_thread () from /lib/x86_64-linux-gnu/libpthread.so.0
#18 0x00007f3779017cbd in clone () from /lib/x86_64-linux-gnu/libc.so.6
#19 0x0000000000000000 in ?? ()



[softcoder]

Try 4182, thanks

[titi]

Now I get a freeze of MG ( kill -9 needed to end it ! )
This always happens now .

I attached with gdb and got this stack:

Code: [Select]

tscharn@tscharn-desktop:~/glest/megaglest/mk/linux$ sudo ./freezestack 5982
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7f2ca09bc700 (LWP 6023)]
[New Thread 0x7f2ca21bf700 (LWP 6022)]
[New Thread 0x7f2ca19be700 (LWP 6021)]
[New Thread 0x7f2ca11bd700 (LWP 6020)]
[New Thread 0x7f2ca37fd700 (LWP 6019)]
[New Thread 0x7f2ca2ffc700 (LWP 5994)]
[New Thread 0x7f2cb5200700 (LWP 5990)]
[New Thread 0x7f2cb5a01700 (LWP 5989)]
[New Thread 0x7f2cb6202700 (LWP 5988)]
[New Thread 0x7f2cba160700 (LWP 5986)]
[New Thread 0x7f2cbab75700 (LWP 5985)]
[New Thread 0x7f2cb6b75700 (LWP 5984)]
0x00007f2cc5e9a9bb in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#0  0x00007f2cc5e9a9bb in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007f2cc5e1e221 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007f2cc5e1bfa7 in malloc () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007f2cc671fded in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007f2cc6708a89 in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007f2cc670a495 in char* std::string::_S_construct<char const*>(char const*, char const*, std::allocator<char> const&, std::forward_iterator_tag) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00007f2cc670a5e3 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7  0x000000000068e6ef in Glest::Game::ExceptionHandler::logError (msg=0x7fffe46f7800 "In [/home/tscharn/glest/megaglest/source/glest_game/main/main.cpp::handleSIGSEGV Line: 5192] Error detected: signal 11:\n", confirmToConsole=true) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:526
#8  0x00000000006acd6a in Glest::Game::ExceptionHandler::handleRuntimeError (msg=0x7fffe46f7800 "In [/home/tscharn/glest/megaglest/source/glest_game/main/main.cpp::handleSIGSEGV Line: 5192] Error detected: signal 11:\n", getStackTraceString=true) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:594
#9  0x00000000006ad4ff in Glest::Game::handleSIGSEGV (sig=<optimized out>) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:5196
#10 <signal handler called>
#11 0x00007f2cc5e17df2 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#12 0x00007f2cc5e19436 in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#13 0x00007f2cc5e1bfb5 in malloc () from /lib/x86_64-linux-gnu/libc.so.6
#14 0x00007f2cc671fded in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#15 0x000000000062582f in allocate (__n=<optimized out>, this=<optimized out>) at /usr/include/c++/4.6/ext/new_allocator.h:92
#16 _M_allocate (__n=<optimized out>, this=<optimized out>) at /usr/include/c++/4.6/bits/stl_vector.h:150
#17 _M_allocate_and_copy<Glest::Game::Unit**> (__last=0x0, __first=0x0, __n=<optimized out>, this=<optimized out>) at /usr/include/c++/4.6/bits/stl_vector.h:1052
#18 std::vector<Glest::Game::Unit*, std::allocator<Glest::Game::Unit*> >::reserve (this=0x7fffe46f9e30, __n=<optimized out>) at /usr/include/c++/4.6/bits/vector.tcc:76
#19 0x0000000000658826 in reserve (__n=500, this=0x7fffe46f9e30) at /usr/include/c++/4.6/bits/vector.tcc:71
#20 clearVolatileCacheData (this=0x7fffe46f9dc0) at /home/tscharn/glest/megaglest/source/glest_game/graphics/renderer.h:140
#21 clearCacheData (this=0x7fffe46f9dc0) at /home/tscharn/glest/megaglest/source/glest_game/graphics/renderer.h:131
#22 Glest::Game::VisibleQuadContainerCache::VisibleQuadContainerCache (this=0x7fffe46f9dc0) at /home/tscharn/glest/megaglest/source/glest_game/graphics/renderer.h:120
#23 0x000000000063bba6 in Glest::Game::Renderer::endGame (this=0xefff60, isFinalEnd=false) at /home/tscharn/glest/megaglest/source/glest_game/graphics/renderer.cpp:742
#24 0x0000000000571156 in Glest::Game::Game::endGame (this=0x3ae7970) at /home/tscharn/glest/megaglest/source/glest_game/game/game.cpp:342
#25 0x000000000057bbda in Glest::Game::Game::exitGameState (program=0x1bc6800, endStats=...) at /home/tscharn/glest/megaglest/source/glest_game/game/game.cpp:4664
#26 0x00000000006c521a in Glest::Game::Program::loopWorker (this=0x1bc6800) at /home/tscharn/glest/megaglest/source/glest_game/main/program.cpp:408
#27 0x00000000006ba391 in Glest::Game::glestMain (argc=<optimized out>, argv=<optimized out>) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:5049
#28 0x00000000006bd1d4 in Glest::Game::glestMainSEHWrapper (argc=1, argv=0x7fffe4703058) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:5288
#29 0x00000000006bd3b2 in Glest::Game::glestMainWrapper (argc=1, argv=0x7fffe4703058) at /home/tscharn/glest/megaglest/source/glest_game/main/main.cpp:5361
#30 0x00007f2cc5dba76d in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
#31 0x0000000000501959 in _start ()


[tomreyn]

I think this can be a different issue, since I didn't have this problem you discussed here initially (50% probability for segfault when exiting).

I do have it on r4148, though. The game actually freezes after printing this line:

Code: [Select]

In [/home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp::handleSIGSEGV Line: 5192] Error detected: signal 11:
Backtrace:

Code: [Select]

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
__lll_lock_wait_private () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:93
93    ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: No such file or directory.
#0  __lll_lock_wait_private () at ../nptl/sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:93
#1  0x00007f62be90a231 in _L_lock_10656 () at malloc.c:5220
#2  0x00007f62be907fb7 in __GI___libc_malloc (bytes=140062084028224) at malloc.c:2921
#3  0x00007f62bf1b560d in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007f62bf2123b9 in std::string::_Rep::_S_create(unsigned long, unsigned long, std::allocator<char> const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007f62bf213d95 in char* std::string::_S_construct<char const*>(char const*, char const*, std::allocator<char> const&, std::forward_iterator_tag) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#6  0x00007f62bf213e73 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#7  0x000000000065da29 in Glest::Game::ExceptionHandler::logError (msg=msg@entry=0x7fff1fe37840 "In [/home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp::handleSIGSEGV Line: 5192] Error detected: signal 11:\n", confirmToConsole=confirmToConsole@entry=true) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:526
#8  0x0000000000679f2a in Glest::Game::ExceptionHandler::handleRuntimeError (msg=msg@entry=0x7fff1fe37840 "In [/home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp::handleSIGSEGV Line: 5192] Error detected: signal 11:\n", getStackTraceString=getStackTraceString@entry=true) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:594
#9  0x000000000067a6cf in Glest::Game::handleSIGSEGV (sig=<optimized out>) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:5196
#10 <signal handler called>
#11 malloc_consolidate (av=0x7f62bec3d740 <main_arena>) at malloc.c:4249
#12 0x00007f62be905446 in malloc_consolidate (av=0x7f62bec3d740 <main_arena>) at malloc.c:4226
#13 _int_malloc (av=0x7f62bec3d740 <main_arena>, bytes=4000) at malloc.c:3543
#14 0x00007f62be907fc5 in __GI___libc_malloc (bytes=4000) at malloc.c:2924
#15 0x00007f62bf1b560d in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#16 0x00000000006118f6 in allocate (__n=<optimized out>, this=<optimized out>) at /usr/include/c++/4.7/ext/new_allocator.h:94
#17 _M_allocate (__n=<optimized out>, this=<optimized out>) at /usr/include/c++/4.7/bits/stl_vector.h:169
#18 std::vector<Glest::Game::Unit*, std::allocator<Glest::Game::Unit*> >::_M_allocate_and_copy<Glest::Game::Unit**> (__n=__n@entry=500, __first=0x0, __last=0x0, this=0x7fff1fe39ee0) at /usr/include/c++/4.7/bits/stl_vector.h:1109
#19 0x000000000063d8cd in reserve (__n=500, this=0x7fff1fe39ee0) at /usr/include/c++/4.7/bits/vector.tcc:76
#20 Glest::Game::VisibleQuadContainerCache::clearVolatileCacheData (this=this@entry=0x7fff1fe39e70) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/graphics/renderer.h:140
#21 0x0000000000646f6d in clearCacheData (this=0x7fff1fe39e70) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/graphics/renderer.h:131
#22 Glest::Game::VisibleQuadContainerCache::VisibleQuadContainerCache (this=0x7fff1fe39e70) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/graphics/renderer.h:120
#23 0x000000000062fc50 in Glest::Game::Renderer::endGame (this=0xe411e0 <Glest::Game::Renderer::getInstance()::renderer>, isFinalEnd=<optimized out>) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/graphics/renderer.cpp:742
#24 0x00000000005939d0 in Glest::Game::Game::endGame (this=this@entry=0x447da10) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/game/game.cpp:342
#25 0x00000000005a3c35 in Glest::Game::Game::exitGameState (program=0x2a28960, endStats=...) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/game/game.cpp:4664
#26 0x00000000006a3042 in Glest::Game::Program::loopWorker (this=0x2a28960) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/program.cpp:408
#27 0x0000000000686b40 in Glest::Game::glestMain (argc=argc@entry=1, argv=argv@entry=0x7fff1fe40a68) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:5049
#28 0x000000000068ac96 in Glest::Game::glestMainSEHWrapper (argc=argc@entry=1, argv=argv@entry=0x7fff1fe40a68) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:5288
#29 0x000000000068ae0b in Glest::Game::glestMainWrapper (argc=1, argv=0x7fff1fe40a68) at /home/tomreyn/SCM/megaglest-trunk/source/glest_game/main/main.cpp:5361
#30 0x00007f62be8a676d in __libc_start_main (main=0x50a0e0 <main(int, char**)>, argc=1, ubp_av=0x7fff1fe40a68, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff1fe40a58) at libc-start.c:226
#31 0x0000000000510689 in _start ()


[softcoder]

Do we still have this crash occurring on svn head?

[tomreyn]

My impression is that this thread discusses more than a single issue.
I am unable to reprodcue the segfault on head of trunk.
However, Titi and I reproduced the freeze you get on a client when the server quits the network game before the client does on r4209. I assume that's the issue Titi dicussed above on: 12 March 2013, 23:03:58. So I'm removing the [fixed] tag Titi had set here.

[titi]

This problem is still there.
The freeze happens often ( not always ) when the server leaves the game. Its not a real freeze, but it takes up to 30 seconds until the client continues.

[softcoder]

Testing with Windows in VirtualBox and Linux as the server i get no delays when the server disconnects in game. Can you give specific steps that i can use to reproduce this?

[tomreyn]

Just for reference: there's a duplicate report.
Titi had tagged this dupe as "crash is fixed" (which I since replaced by "[dupe]"), so I think we can safely assume that the crash discussed previously in this thread (as well as in the dupe) is no longer occurring.

Titi: It would still be nice if you could actually confirm that there is no longer any crashing involved (since you never did so on this topic). For the future, while we continue to use the forums for bug reporting and triage (which we seem to agree is not a good idea), please split topics as soon as it's clear that the topic is now moving in a different direction where a new or different (even if related) topic is being discussed. On the other hand, let's try to merge duplicate reports whenever possible (without breaking their context). If merging doesn't work, let's add cross-references to both topics and mark one of them as a [dupe]. This will make it much easier to follow-up on what is already fixed and what is not.

Back on topic:
Yesterday Titi, Atze and I played a longer game with the Japanese tech tree on the large Japan map with Titi's new birch forest tileset. Titi was hosting and Atze and I were clients. When the game was over and Titi shut down the host, my game froze for roughly 15 seconds. So the freeze issue described in this thread can still occur, but for me it seems to do so only rarely now, and with much lesser impact. On previous 3.8-dev SVN revisions these freezes, also triggered by the game host leaving, would occur every time and would easily last for minutes. So the impact seems to have decreased much, at least for me, based on (only) three tests we did on the latest SVN revisions so far.

[softcoder]

Is this bug fixed now for svn head?

[tomreyn]

It's not perfect, yet (as I tried to describe in my latest post). But I think we can consider the original issue fixed, and if we consider it necessary we can open another report on those - now much shorter, just some seconds - client freezes when the server ends the game.