[fixed] r4260: Overloading tutorial localizations with $UserData_Root fails

[filux]

If someone does the translation, and then use the advanced translation and have been download files from transifex then only those translations from the main file, hints and scenarios are taken into account, and the rest you need manually swap. The situation is identical to 3.7.1 and the latest svn. Would have been nice to make the game seen also the rest of the files (tutorials).

Summary (tomreyn):
Overloading tutorial (but not scenario) localizations with what's stored in $UserData_Root/ does not work. As such, it is currently not possible to test tutorial localizations made on Transifex.

[tomreyn]

I agree, and it almost qualifies as a bug. I can't think of any reason why tutorials shouldn't be downloaded, too.

[filux]

Clarification, because I see now, I described the problem ambiguously. 

The files are downloaded but not working, they are not swapped when you start a tutorial.

[tomreyn]

You say "the [tutorial] files are [..] not swapped when you start a tutorial".

Can you explain what you mean by "not swapped"?
Which language is your game set to before you start testing the downloaded translations?
What do you do, what happens as a result, and what would you expect to happen as a result of your actions instead?
Put different: what's the exact process (which will have to include changing the currently set game language) to reproduce this issue?

Thanks.

[filux]

Hmm, ok 
E.g. 1_very_basic_tutorial

linux x64 OS =>
language in game set to - Polish =>
then I changed something in Polish tutorial on transifex (with saved changes) =>
then in-game in menu Options>Misc>Advanced Translation I enter my transifex login details with language code "pl" =>
then click to a "Download from transiflex" button and I get the message about the success of downloading =>
then I run the game and this tutorial =>
then I see a old translation in this tutorial  (does not take into account my changes )
[ at this point all other translated files work well without of contriving  ] =>

I expect from game a identical treatment the tutorials' files as the other translated files.

{
Now when I want to see the new version of translation the tutorial, I have to manually copy the file or make a symlink to it (much worse solution)

from the location:
~/.megaglest/tutorials/1_very_basic_tutorial/1_very_basic_tutorial_polish.lng

to the location:
/usr/share/megaglest/tutorials/1_very_basic_tutorial/1_very_basic_tutorial_polish.lng   [for 3.7.1] (root permissions needed)

or to the location:
~/mglestsvn/data/glest_game/tutorials/1_very_basic_tutorial/1_very_basic_tutorial_polish.lng   [for svn]
}

[tomreyn]

Thanks for explaining.

I believe what you are looking for is already implemented. Game data stored in ~/.megaglest/ should always overload data located in the installation directory.

However, you need to ensure that the game actually loads the language files you download from Transifex. The easiest way to do so is to press Ctrl-L and to click on the language which you just downloaded from Transifex. Copying files around should not be necessary.

I have not actually tested this, though. I'll do this in a next step if you are convinced that it still fails to work when you make the game reload the language files after you downloaded them from Transifex.

[filux]

Still doesn't working.

The test consisted of:
Making changes in the tutorial file at the location ~ /. megaglest / ...
- then selecting the Polish language (Ctrl + L),
- changing the language between English > Polish and Polish > English (Ctrl + L).
These tests have been made with a procedure: "run a game > test > turning off a game > run a game > test > ... ".

[tomreyn]

Confirmed. Thank you, Filux.

Since I consider this to be a bug, I've moved it to the bug forum.

[filux]

For me, scenarios works fine.
3.7.1 doesn't support "SCENARIO_NAME=" var and this can be confusing .
E.g.: a moment ago tested on "Amazones".

[tomreyn]

Thanks for testing scenarios, I've updated the title accordingly.

[softcoder]

This is fixed in svn rev#: 4299

[filux]

Now it looks that works fine.