[fixed] Clicking on the window's X button to end the process makes MG crash

[Omega]

I tried out rev 4260. Attempting to close the window while in the "internet game" screen crashed the program with an error. It looped an infinite number of dump files, and I've uploaded the first one here. I was able to reproduce this issue each time. Program was customly compiled with Microsoft Visual Studio 2010 using the included batch files. Noteworthy that despite the fact I was using the most recent version of the SVN trunk, there may have been files out of date, since I had a language string warning about an unset username when entering the internet game screen.

I also got this error, which was not written to any logs:



Because the dump files were continuously created, I had to kill the process from the task manager.

I'm not sure if this part is any use, but here's the output from --verbose as a 154 KB pastebin: http://pastebin.com/raw.php?i=Rvj6jVgt

EDIT: I didn't post this as a new topic because it was meant to follow up a feature implementation (or bug fix?). Since it has now been moved, additional details are required: this bug is likely caused by the changes in rev 4259, as it was not reproduceable in prior versions and only occurs when exiting the internet game screen, which formerly hung for several seconds before closing. As mentioned by Carolinus, this does not affect closing the game window from other screens. Closing the game window is defined as clicking the "x" in windowed mode.

[carolinus]

Hello,

win7 home 64bit, i can reproduce the same error on my machine using r4260 (using "exit" button ingame menu just after end  internet game)
Exiting from other games (standard, LAN) seems to work w/o this problem.
---------------------------
Unhandled error
---------------------------
An unhandled error was detected.

A crash dump file has been created in the folder:
C:\Users\xxxx\AppData\Roaming\megaglest\
Crash dump filename is: 4dbfee3c-8b2a-478c-98ca-5cdf4c3c0e5e.dmp
---------------------------
OK   
---------------------------

[softcoder]

Should now be fixed in svn rev#: 4262

[Omega]

Using rev 4262:

I did not receive the same crash errors as previously mentioned. Or more accurately, I did not receive the errors every time. However, the window still takes awhile to close (about 10 seconds).

Further, I still seem to be receiving the errors occasionally, but not all the time like before. Even more, I received two different types of errors. I'm not sure if they're from the same source.



The second error seems to resemble that of the original:



Here's the verbose output from the second error: http://pastebin.com/raw.php?i=zsZunc3c

While I have been able to reproduce the crash multiple times (somewhat uncommon; maybe 10% of the time), I have not been able to find steps to reproduce the issue. Hopefully the verbose output might provide some help?

Possibly related is that MG always crashes if I close when the "username not set" message comes up (no error message; dmp and verbose log here).

EDIT: To clarify, the first error message was only received once and I cannot figure out how to reproduce it (so no verbose output either). The second error is sometimes reproducible (yeah, I know, that's not very helpful) but I was able to get verbose output. The third crash (without an error) is reproducible 100% of the time.

[carolinus]

win7 home 64, rev 4263 compiled by "build-mg-2010.bat"
cpu b950, graph: hd3000/nvidia

test1
playing few min  (host game then start game vs cpu and for few sec with another player)

exit from game using exit button = error
---------------------------
Unhandled error
---------------------------
An unhandled error was detected.

A crash dump file has been created in the folder:
C:\Users\xxx\AppData\Roaming\megaglest\
Crash dump filename is: 44a5dba5-742a-4100-8ddf-93462d3bffa6.dmp
---------------------------
OK   
---------------------------
---------------------------
MegaGlest fatal error
---------------------------
Access violation. Illegal write by 1528852041 at 15288520411528852041|Unknown module|Unknown function
8640985|Unknown module|Unknown function
6157365|Unknown module|Unknown function
6157843|Unknown module|Unknown function
6157952|Unknown module|Unknown functi []
---------------------------
OK   
---------------------------

test2
the same as above except time
- just few sec in game (after host game and play vs cpu)

exiting from game using "exit" button w/o errors but slower than older rev (<4260)

test3 in progress

[softcoder]

Try this with the latest svn rev, should now be fixed

[tomreyn]

Based on my tests, this is indeed [fixed].

[carolinus]

win7 home 64bit, snv 4287

confirmed - in this version there is no error when game exiting