[fixed] r4287 Rejoin: Admin cannot disconnect player who rejoined into same slot

[filux]

Doesn't work "kicking" player (during a battle), which rejoined to the same slot as was previously.

It can be very disruptive error, if is someone who want impede game to others. 


Edit (tomreyn, 2013-05-26):

I'll try to provide a summary of what I currently understand this is about:

This report is about the new feature where you may re-join a game which is already running. The problem is that a player who disconnects / is disconnected from a game and later re-connects can no longer be forcefully disconnected by the game admin.
To reproduce:

• Host a game, and have a second player join (you may want to add an easy magic CPU opponent but this is not necessary to reproduce)
• Set the game up so that it allows for re-joining (advanced options)
• Start the game
• The client player voluntarily disconnects or is forcefully disconnected by the server admin (using in-game menu)
• The client re-joins the game, selecting the same slot he was using when the game started originally
• The admin tries to forcefully disconnect this player, but this player is not listed  in the in-game menu (but he should be).

Edit (tomreyn, 2013-05-29):
[fixed].

[softcoder]

Please provide the exact steps you made to recreate this bug.
Anytime a bug is entered we need to know the exact steps used so we can properly fix it.

[filux]

E.g.
setup the battle (e.g. 2 players) and run > 
player (not admin) disconnect himself or was kicked by admin >
player rejoin to the same slot as previously >
from now admin can't kick this player anymore 
(button with nickname in menu not exist)

[softcoder]

Should be fixed in svn rev: 4323

[filux]

Issue still exist.

[softcoder]

try svn rev#: 4325

[filux]

Issue still exist.
During the test: server (admin) was on r.4325 and client was on r.4323.

[softcoder]

Provide EXACT steps for failure, i tested and it does work. This will NOT work for a headless admin currently.

[filux]

Tested a moment ago, both clients were r.4325.

setup the battle, map for 4 players-conflict, first slot to admin, second slot to client, third slot to cpu(easy), fourth slot closed>
run game>
admin kicked client succesfully>
client rejoined to old slot, (here almost always game put you to the third cpu slot, then you should change your place to second slot manually)>
run game>
from now admin can't kick client anymore 

 

[softcoder]

Are you doing this on your computer as the host or using headless server? This does not work for headless, it does work for me when i test it as host.

[filux]

computer as the host

... but ...
I think that perhaps my testing method that I use in this case fails (in any other so far worked well).
The both clients games are running on one computer and on one system, and it can affect on not properly recognized player or something like that.

I think that it is worthwhile organize a common test

[tomreyn]

Filux and I just reproduced this.
I hosted, started the game after he joined. Then while the game was running, I kicked him from in-game menu. Then he reconnected to (and rejoined) the running game (I had this option enabled). The game continued with him in. I tried to kick him again, but the context menu looked exactly as on his screenshot posted above: there was no entry for him on the list of players who may be disconnected.

[softcoder]

I tried this exact scenario and i was able to disconnect the player twice:

1. Both client and host are in game lobby
2. Host starts the game (with rejoin enabled)
3. Host presses ESC select disconnect menu and selects the player to drop and answers Yes
4. Client is dropped from game
5. Client reconnects in progress game (at this point you should already be able to drop the connected player)
6. Client clicks join in progress game
7. Host is able to disconnect player again using steps 3-4

[tomreyn]

Are you making sure the rejoining player is in the same player slot again?

[filux]

I tried this exact scenario and i was able to disconnect the player twice:

1. Both client and host are in game lobby

[host - admin screen, battle configuration]

2 + one cpu e.g. easy
(when game blocking rejoin to kicked player on 1vs1)

2. Host starts the game (with rejoin enabled)
3. Host presses ESC select disconnect menu and selects the player to drop and answers Yes
4. Client is dropped from game
5. Client reconnects in progress game (at this point you should already be able to drop the connected player)

5. yes, it is. in lobby before a rejoin it is possible at least one time (one time was tested)

Now you (client - "kicked player") have to make sure that you are on previously slot - in this case second - blue.
(here almost always game put you to the third cpu slot,


[client - "kicked player" screen, not on previously slot.]

then you have to change your place to second slot manually)


[still client - "kicked player" screen, after manually changed slot]

6. Client clicks join in progress game

[client - "kicked player" screen]


[host - admin screen]


[host - admin screen, from now admin can't kick client anymore ]

[softcoder]

Ok key was the SAME slot, fixed now in svn rev#: 4333

[tomreyn]

Yes this seems to be [fixed], thanks for fixing, and for going to lengths to describe the issue.