[Fixed] r4338: Rejoin: Duplicate savegame download?

[tomreyn]

When Filux and I were testing r4338 tonight with rejoin enabled, I was reconnecting to his server a couple times. Every time I reconnected / rejoined his game, two file downloads were shown, both of which seemed to be savegame files, one with a .XML and one with a .ZIP file extension. Is it possible that the .XML file should have been removed when .ZIP was introduced but this was forgotten? Or are these just different files?

[softcoder]

Try again and see if this is reproducible. Special note of you click cancel during save game download it will now disconnect you.

[tomreyn]

This was reproducible yesterday (reproduced twice, so 3 times overall). Cancelling wasn't possible the way we tested yesterday, since the download was too quick either way. I'll try next time I get a chance to do it.

[tomreyn]

Filux and I tried again today. He was hosting, I was joining the game which he had started some minutes ago.
The first time I tried to join I cancelled the savegame download and was disconnected as a result.
The second time I tried to join I let the savegame download finish and joined properly.
However, there were still two file downloads both times, looking exactly as on the screenshot above.

[softcoder]

retest on 4357, thanks

[tomreyn]

Atze (host) and I just tried again on r4357. Now the names of the files you download when joining have changed.

Previously:
megaglest-saved-client.xml
megaglest-saved-client.zip

Now:
megaglest-saved-client.zip
megaglest-saved-server.zip

After clicking "Play now!" the game now stalls for some seconds on the client. That's probably while the server is taking a savegame and compressing it. This used to be faster, I think, and if it will keep freezing then it would be good to post a message to the client saying "please stand by, dumping, downloading and restoring savegame" or something. It's also unclear whether the download of megaglest-saved-server.zip (second file) finishes before the join process starts. (It probably does but the download is quick.)

Screenshot:

[softcoder]

Should be fixed in 4358.

[tomreyn]

Yes, it downloads only one file now, and so fast that I couldn't tell which (testing on localhost, though). [Fixed].