r4341: Rejoin: When multiple players join simultaniously, game may never resume

[tomreyn]

There are some oddities with rejoin and pausing. When you have a game where players will disconnect and reconnect repeatedly then you will run into this situation where one of them rejoins, and there is no player currently in process of joining, but the game does not resume - it remains paused. I'm not exactly sure what triggers it, maybe there are situations where clients get stuck in the join in sequence, maybe due to the game state download progress messages. When you setup a game with multiple network clients and they rejoin, and some rejoin at the same time (I'm not sure this is actually necessary to reproduce) this issue is guaranteed to occur.

Edit (tomreyn, 2013-06-01): better subject title

[softcoder]

Try to see if this is fixed in 4388 as I tried to make this more stable

[tomreyn]

One situation which I now know triggers this, and still does so on r4394, is when a joining player hits the "play now" button repeatedly (maybe more than once is sufficient). Zhis player will then join, but the game doesn't resume. If the server admin tries to resume it manually, it does so, but just for one frame, then pauses again. Further attempts to resume the game result in the same behaviour, so the game is no longer playable.

[softcoder]

Hopefully fixed in 4398

Edit by tomreyn (2013-06-21):

Note to self: I'm not sure whether or not this was fixed, needs more testing (and an update to this post) when we look into rejoins again.