[invalid] r4378: Warnings during the compilation related with compression

[filux]

Every compilation which contain something from compression libs (e.g. every full rebuild  ) show multiple warnings like this:

Code: [Select]

[ 27%] ...
In file included from /home/filux/mglestsvn/source/shared_lib/sources/compression/compression_utils.cpp:20:0:
.../source/shared_lib/sources/miniz/miniz.c:3393:27: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:3382:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:3293:39: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:3059:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2975:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2970:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2963:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2957:31: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2942:28: warning: always_inline function might not be inlinable [-Wattributes]
In file included from /home/filux/mglestsvn/source/shared_lib/sources/compression/compression_utils.cpp:20:0:
.../source/shared_lib/sources/miniz/miniz.c:2440:28: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2432:28: warning: always_inline function might not be inlinable [-Wattributes]
.../source/shared_lib/sources/miniz/miniz.c:2230:28: warning: always_inline function might not be inlinable [-Wattributes]
[ 27%]...
That is confusing  while the compilation contained some warnings and on end we see:

[100%] Built target megaglest.6
BUILD COMPLETE.

[softcoder]

Thats not a bug its code we use written by another project.

[filux]

If "not inlinable" isn't a bug then in my opinion warnings are
unnecessary and confusing and themselves are issue and should disappear.

In my point of view the correct compilation should proceed without any errors and warnings.

[tomreyn]

These warnings are about source code of a library written by someone else, which MegaGlest reuses. You could notify its author about it, but really they are just warnings.

You can configure your compiler not to output these warnings by passing -Wno-attributes to gcc if you so wish.

[filux]

This is not for me, because now I know it,
but I assume that in the future you guys probably many times will be asked about these warnings, by other people.

I think you shouldn't forget about that and if/when will be an opportunity to improve this.

For example, in the past, I have searched and downloaded manually all the libraries on which compiler wrote that can't find them.
I Introduced a change in the file build-mg.sh to compiler too, to not yelling about not found an IRC client.
During compilation everything should looks flawless, then I know that it must working good.