[fixed] r4400: Strange entries and requirements in factions' upgrade section

[filux]

Maybe I'm wrong  but I can't imagine why "upgrade" section (faction>upgrades>upgrade folder>upgrade.xml) required own entries "image" and "image_cancel" and apparently the game loads these images and wastes resources?

<upgrade>
   <image path="..."/>
   <image-cancel path="..."/>
   ...
</upgrade>

If I'm right please eliminate the requirement of existence of these entries and images inside them,
and in order to backwards compatibility, lock the game ability using them even if they exist. 

[softcoder]

This is not a bug. These images are shown when you upgrade or cancel an upgrade. I have no idea what you think the bug here is.

[filux]

In my opinion not these

example> persian's tent:
 These images are shown when you upgrade or cancel an upgrade.

Code: [Select]

<?xml version="1.0" standalone="no" ?>
<unit>
<!-- *** parameters *** -->
<parameters>...
<image-cancel path="../genie/images/tech_cancel.bmp"/>...
</parameters>...
<commands>...
<command>...
<image path="../../upgrades/magic_level_1/images/magic1.bmp" />...
</command>...
</commands>
</unit>
and that persian's upgrade
 These images aren't shown when you upgrade or cancel an upgrade.
Please try change it to any other existing .bmp image and check of something has changed anywhere in game.
Personally I don't see any difference.

Code: [Select]

<?xml version="1.0" standalone="no"?>

<upgrade>
<image path="images/magic1.bmp"/>
<image-cancel path="../corn_and_wicker/images/tech_upgrade_cancel.bmp"/>
...
</upgrade>
Tent has own menu and here images are shown. Upgrade hasn't own menu.
   

[softcoder]

I think you are right that upgrades images are not actually used anywhere, just incorrectly added in the xml and blindly read in the code, I will look at fixing this.

Fixed in svn, we no longer look for those xml tags. We can delete the images from megapack if titi agrees as they are not used.

[filux]

I confirm that is fixed, thx 

On this example, unnecessary is only one image:
"../corn_and_wicker/images/tech_upgrade_cancel.bmp"
..., magic.bmp is still used but only once now

Currently I am working a little on megapack (link) and you should wait for the results of my work, because I take into account this discovery