Author Topic: [invalid] r4400: Techtree vallidator duplicates false positives?  (Read 557 times)

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
The techtree validator currently outputs the following for Megapack:
Quote
Duplicates 28.59 MB (373) in files

However, it is my understanding that Titi thinks these files are actually needed. As such (and if this is so), these seem to be false reports and the deduplication mechanism of the techtree validator needs to be adjusted.
« Last Edit: 17 June 2013, 11:12:30 by tomreyn »
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·

filux

  • MegaGlest Team
  • Draco Rider
  • ********
  • Posts: 310
  • was OpenSuse x64, is Debian testing x64
    • View Profile
Re: r4400: Techtree vallidator duplicates false positives?
« Reply #1 on: 9 June 2013, 04:53:26 »
I my opinion definitely false positives.
For example, there are plenty of identical (duplicate) models, but graphics (. tda) for these models are different, and it makes the same model looks different.

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: r4400: Techtree vallidator duplicates false positives?
« Reply #2 on: 20 June 2013, 21:45:45 »
Duplicate are duplicates. You only need 1 version of the model. If the model CRC is the same then its a duplicate. IF the folder have different images thats ok. In the end the duplicate cleanup currently only works on sounds because titi did not want to weed out duplicates more than that. The Debian games team actually DOES remove duplicates (which is passed onto the Ubuntu distro) and they create links to the single files for ALL data and MG works fine. That proves that we can also do it but Titi prefers not to do this.

This is not a bug, the report is accurate, if you feel it is not then please provide specific details.

Thanks

tomreyn

  • Local Moderator
  • Airship
  • ********
  • Posts: 2,764
    • View Profile
    • MegaGlest - the free and open source cross platform 3D real-time strategy game
Re: r4400: Techtree vallidator duplicates false positives?
« Reply #3 on: 20 June 2013, 23:00:35 »
Thanks for the explanation.

So Megapack (the way we distribute it) contains duplicates, which is intentional and thus not a bug, I just wasn't aware of this.
atibox: Ryzen 1800X (8 cores @3.6GHz), 32 GB RAM, MSI Radeon RX 580 Gaming X 8G, PCI subsystem ID [1462:3417], (Radeon RX 580 chipset, POLARIS10) @3440x1440; latest stable Ubuntu release, (open source) radeon (amdgpu) / mesa video driver
atibox (old): Core2Quad Q9400 (4 cores @2.66GHz), 8 GB RAM, XFX HD-467X-DDF2, PCI subsystem ID [1682:2931], (Radeon HD 4670, RV730 XT) @1680x1050; latest stable Ubuntu release, (open source) radeon / mesa video driver
notebook: HP envy13d020ng
internet access: VDSL2+

· · · How YOU can contribute to MG · Latest development snapshot · How to build yourself · Megapack techtree · Currently hosted MG games · · ·