Author Topic: [fixed] r4598: rock textures are gone  (Read 802 times)

atze

  • Technician
  • ****
  • Posts: 119
    • View Profile
[fixed] r4598: rock textures are gone
« on: 8 October 2013, 18:04:18 »

Testing svn rev. 4598 I noticed that rock textures are not longer rendered.

Here are 2 screenshots with the same settings (tileset), for better understanding.

Screenshot 3.8.0 beta1 :
(click to show/hide)

Screenshot svn rev. 4598 :
(click to show/hide)

My system:

Linux 64 bit, ATI driver 8.97.100.7, running MegaGlest r4598 (which I compiled myself)
this signature is not available in your country

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: r4598: rock textures are gone
« Reply #1 on: 8 October 2013, 19:20:58 »
It seams to be a problem with the cliff detection, as not all cliffs are rendered as cliffs. See screenshot.

(click to show/hide)

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: r4598: rock textures are gone
« Reply #2 on: 15 October 2013, 22:31:25 »
I detected an difference in calculation of isCliff.  It's different for map editor and game. The tolerance for map_preview seems to be better for more cliffs.

map.cpp 1617   versus  map_preview.cpp 76

I debugged values for a cell that is cliff in editor but in game it is not:

Code: [Select]
(STREFLOP) X: 88 Y: 121 K: -1 L: -1-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: -1 L: 0-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: -1 L: 1-> Cliff: 6.000000 compare: 5.475202 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: -1-> Cliff: 6.000000 compare: 1.083045 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 88 Y: 121 K: 0 L: 1-> Cliff: 6.000000 compare: 0.252266 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: -1-> Cliff: 6.000000 compare: 2.475202 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: 0-> Cliff: 6.000000 compare: 0.134478 smooth
(STREFLOP) X: 88 Y: 121 K: 1 L: 1-> Cliff: 6.000000 compare: 0.318521 smooth



Here is the debugging for a field with working cliff.

Code: [Select]
(STREFLOP) X: 100 Y: 117 K: -1 L: -1-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: -1 L: 0-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: -1 L: 1-> Cliff: 6.000000 compare: 6.666667 cliff
(STREFLOP) X: 100 Y: 117 K: 0 L: -1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 0 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 0 L: 1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: -1-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: 0-> Cliff: 6.000000 compare: 0.000000 smooth
(STREFLOP) X: 100 Y: 117 K: 1 L: 1-> Cliff: 6.000000 compare: 0.000000 smooth

« Last Edit: 16 October 2013, 10:38:20 by MuwuM »

softcoder

  • MegaGlest Team
  • Battle Machine
  • ********
  • Posts: 2,239
    • View Profile
Re: r4598: rock textures are gone
« Reply #3 on: 17 October 2013, 03:27:25 »
Try svn, I think i fixed this bug

MuwuM

  • Ornithopter
  • *****
  • Posts: 426
  • No Game without Move(ment)
    • View Profile
    • MuwuM - Lexicons
Re: r4598: rock textures are gone
« Reply #4 on: 17 October 2013, 18:48:21 »
fixed for me