[fixed] v.3.10.0-beta1 Romans general without shine?

[nig]

Hi!
Maybe nothing serious:
I played  v.3.10.0-beta1 [Rev: 4905.58cba20] on Win7 64 and recognized, that the roman general does not show his halo as in the other versions of MG. There are no halos on the affected units too.

did you cancel roman generalism in 3.10?

Greetz
nig

[titi]

hi, thanks for reporting!

We fixed something related to this, can you test the latest version too and see if its fixed already ?
http://snapshots.megaglest.org/windows/megaglest-binary-win32-i386-3.10.0-beta1.7z

You will just need the binary( exe-file ) and its compatible with the beta release.

[nig]

still nothing...

[filux]

I just tested this on head [Rev: 4948.5b82859]. It is not just a shine, boost also doesn't work. I bet it is somehow related with "tags".

[titi]

Yes, I tested it and its exactly the tags feature which broke it. One revision before it worked.
Lets see how to fix it.

Update: I already fixed it locally, but I saw another error with boosts which I want to fix too before checkin( its this: https://forum.megaglest.org/index.php?topic=9500.0 )

[titi]

this is fixed now in revision d34e58ccb64c1f4bfe9bda021d5e7b419c76b045 from Dec 15, 2014 please try it.
( this version is no longer beta compatible )

[filux]

"Shine" is fixed ... but I found another problem  ;D
not so sure, but seems like it is a quite serious bug

how reproduce:
romans & all upgrades > produce archer > you see attack strength  15...125+28 > now move general next to this archer > you see attack strength  15...125+24 ( :look: strange) > now move general away from archer > you see attack strength  15...125 (  :o very strange)

Where disappeared +28 from upgrades?
 

[nig]

 on [Rev: 4951.d34e58c]  boosted units have shine again.
and i get an unhandled error on the first attack of the general...
crash.dmp:
http://www.fastshare.org/download/e9dd11b8_8fc4_4dd1_ab9d_4013343de54d.zip

second try MG stayed stable.

Greetz
nig.