[fixed]more boost trouble

[filux]

... how reproduce:
romans & all upgrades > produce archer > you see attack strength  15...125+28 > now move general next to this archer > you see attack strength  15...125+24 ( :look: strange) > now move general away from archer > you see attack strength  15...125 (  :o very strange) ...

On the [Rev: 4958.b5d6095] it is fixed, but I found something new:

(The same old save game may be used to test this. >)

how reproduce:
the same start, romans & all upgrades > produce archer > you see sight 15+1 and you see armor 10+6 > now move general next to this archer > you see sight 15+3 (should be +2) and you see armor 10+12 (should be still +6)

... because general gives boost: +1 to sight and nothing to armor

[titi]

I splitted this into its own topic as it has nothing to do with the original bug.

What I found out so far is that the "bless of Minerva" upgrade is given to the archer too, also it is not upgraded yet. This happens in the moment when the general gets into range. Somehow boosts get mixed with upgrades.
This upgraded is already loaded (void TotalUpgrade::loadGame(const XmlNode *rootNode))  to the archer somehow when the game loads

[titi]

Here a scenario without load game, which shows the exactly same (wrong) behavior:
when scenario starts the upgrade "bless_of_minerva" is upgrading in the temple. When its done, walk with the archer out of the boost range of the general ( press '?' key and use debug view to see the range ). Now walk back into the generals boost range.

Watch the armor of the archer all the time and you will see what's wrong.

[titi]

softcoder fixed this in git version and filux and me found no more trouble with attack-boosts now. So I asume its fixed now